Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2280253002:
A11y improvements for quick unlock settings (Closed)
|
Created:
4 years, 3 months ago by xiaoyinh(OOO Sep 11-29) Modified:
4 years, 3 months ago CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionA11y improvements for quick unlock settings
1. Make screen lock element tab reachable
2. Add a button on the overlay
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG=641591
Committed: https://crrev.com/52a7b63c62cead577ede092be908b7027e45e3cd
Cr-Commit-Position: refs/heads/master@{#415080}
Patch Set 1 #Patch Set 2 : rebase #
Messages
Total messages: 24 (17 generated)
Description was changed from ========== incorporate A11y review comments 1. Make screen lock element tab reachable 2. Add a button on the overlay ========== to ========== incorporate A11y review comments 1. Make screen lock element tab reachable 2. Add a button on the overlay CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
xiaoyinh@chromium.org changed reviewers: + jdufault@chromium.org, xiyuan@chromium.org
lgtm
Do you have a bug? If so, please add that to CL description The subject is too vague. Reader does not see what this CL is about from a glance. How about: A11y improvements for quick unlock settings Otherwise, lgtm
Description was changed from ========== incorporate A11y review comments 1. Make screen lock element tab reachable 2. Add a button on the overlay CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== A11y improvements for quick unlock settings 1. Make screen lock element tab reachable 2. Add a button on the overlay CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation BUG=641591 ==========
On 2016/08/26 22:43:51, xiyuan wrote: > Do you have a bug? If so, please add that to CL description > > The subject is too vague. Reader does not see what this CL is about from a > glance. How about: > > A11y improvements for quick unlock settings > > Otherwise, lgtm Thanks Xiyuan! I just create a new bug and link to it. Also changed the subject.
The CQ bit was checked by xiaoyinh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by xiaoyinh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by xiaoyinh@chromium.org
The CQ bit was checked by xiaoyinh@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org, jdufault@chromium.org Link to the patchset: https://codereview.chromium.org/2280253002/#ps20001 (title: "rebase")
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by xiaoyinh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== A11y improvements for quick unlock settings 1. Make screen lock element tab reachable 2. Add a button on the overlay CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation BUG=641591 ========== to ========== A11y improvements for quick unlock settings 1. Make screen lock element tab reachable 2. Add a button on the overlay CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation BUG=641591 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== A11y improvements for quick unlock settings 1. Make screen lock element tab reachable 2. Add a button on the overlay CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation BUG=641591 ========== to ========== A11y improvements for quick unlock settings 1. Make screen lock element tab reachable 2. Add a button on the overlay CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation BUG=641591 Committed: https://crrev.com/52a7b63c62cead577ede092be908b7027e45e3cd Cr-Commit-Position: refs/heads/master@{#415080} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/52a7b63c62cead577ede092be908b7027e45e3cd Cr-Commit-Position: refs/heads/master@{#415080} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
