No longer store the compilation-context in WorkItem.

No longer store the compilation-context in WorkItem.

This context is pretty local to SSA and just needs to be plumbed from the
builder through the optimizers. This way we don't have reference to this context
anywhere else in the compiler.

R=sra@google.com

Committed: https://github.com/dart-lang/sdk/commit/e0c9d843b9bd95d1fe6ab8b7b8fddf4712908df9

[Siggi Cherem (dart-lang), 2016-09-02 22:26:37]

sigmund@google.com changed reviewers:
+ het@google.com, sra@google.com

[Siggi Cherem (dart-lang), 2016-09-02 22:26:38]

https://codereview.chromium.org/2302363003/diff/1/pkg/compiler/lib/src/ssa/bu...
File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):

https://codereview.chromium.org/2302363003/diff/1/pkg/compiler/lib/src/ssa/bu...
pkg/compiler/lib/src/ssa/builder_kernel.dart:37: HGraph build(CodegenWorkItem
work, SsaCompilationContext context) {
not in use yet, but it will be :)

[sra1, 2016-09-02 22:36:33]

lgtm

[Siggi Cherem (dart-lang), 2016-09-02 22:51:14]

... hold on, simplifying further!

[Siggi Cherem (dart-lang), 2016-09-02 23:05:17]

Patchset #3 (id:40001) has been deleted

[Siggi Cherem (dart-lang), 2016-09-02 23:18:53]

Patchset #3 (id:60001) has been deleted

[Siggi Cherem (dart-lang), 2016-09-02 23:20:41]

Patchset #3 (id:80001) has been deleted

[Siggi Cherem (dart-lang), 2016-09-02 23:24:04]

ok - all set

I removed context altogether at this time. Turns out that there were 2 fields in
context:
- allocatedFixedLists is information computed at build time and we now provided
together with HGraph. We can improve how we represent this in the future, but
this is a good place to put it meanwhile.
- boundedChecks was used between passes in optimize.dart, this was not used
anywhere else so now we just create it locally and pass it along locally.

[sra1, 2016-09-02 23:32:03]

lgtm

[Siggi Cherem (dart-lang), 2016-09-02 23:36:45]

Description was changed from

==========
No longer store the compilation-context in WorkItem.

This context is pretty local to SSA and just needs to be plumbed from the
builder through the optimizers. This way we don't have reference to this context
anywhere else in the compiler.
==========

to

==========
No longer store the compilation-context in WorkItem.

This context is pretty local to SSA and just needs to be plumbed from the
builder through the optimizers. This way we don't have reference to this context
anywhere else in the compiler.

R=sra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e0c9d843b9bd95d1fe6ab8b7b8fddf4712908df9
==========

[Siggi Cherem (dart-lang), 2016-09-02 23:36:46]

Committed patchset #4 (id:120001) manually as
e0c9d843b9bd95d1fe6ab8b7b8fddf4712908df9 (presubmit successful).