Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: pkg/compiler/lib/src/ssa/builder.dart

Issue 2302363003: No longer store the compilation-context in WorkItem. (Closed)
Patch Set: ... lint Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/serialization/task.dart ('k') | pkg/compiler/lib/src/ssa/interceptor_simplifier.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/ssa/builder.dart
diff --git a/pkg/compiler/lib/src/ssa/builder.dart b/pkg/compiler/lib/src/ssa/builder.dart
index 76eb247d677661aeb78a9a1706bf708a4d6e24c3..042ac75d1b569b5cdba7d3af37d1698eca6ad3dd 100644
--- a/pkg/compiler/lib/src/ssa/builder.dart
+++ b/pkg/compiler/lib/src/ssa/builder.dart
@@ -86,7 +86,6 @@ class SsaBuilderTask extends CompilerTask {
SsaBuilder builder = new SsaBuilder(
work.element.implementation,
work.resolvedAst,
- work.compilationContext,
work.registry,
backend,
emitter.nativeEmitter,
@@ -117,7 +116,7 @@ class SsaBuilderTask extends CompilerTask {
} else {
name = "${element.name}";
}
- compiler.tracer.traceCompilation(name, work.compilationContext);
+ compiler.tracer.traceCompilation(name);
compiler.tracer.traceGraph('builder', graph);
}
return graph;
@@ -368,10 +367,6 @@ class SsaBuilder extends ast.Visitor
/// SSA graph), when dump-info is enabled.
final InfoReporter infoReporter;
- /// If not null, the builder will store in [context] data that is used later
- /// during the optimization phases.
- final JavaScriptItemCompilationContext context;
-
/// Registry used to enqueue work during codegen, may be null to avoid
/// enqueing any work.
// TODO(sigmund,johnniwinther): get rid of registry entirely. We should be
@@ -428,7 +423,6 @@ class SsaBuilder extends ast.Visitor
SsaBuilder(
this.target,
this.resolvedAst,
- this.context,
this.registry,
JavaScriptBackend backend,
this.nativeEmitter,
@@ -4210,9 +4204,7 @@ class SsaBuilder extends ast.Visitor
// Overwrite the element type, in case the allocation site has
// been inlined.
newInstance.instructionType = elementType;
- if (context != null) {
- context.allocatedFixedLists.add(newInstance);
- }
+ graph.allocatedFixedLists?.add(newInstance);
}
// The List constructor forwards to a Dart static method that does
« no previous file with comments | « pkg/compiler/lib/src/serialization/task.dart ('k') | pkg/compiler/lib/src/ssa/interceptor_simplifier.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698