Configure font font names in GFX unittests

ui/gfx/font_names_testing.h

Index: ui/gfx/font_names_testing.h
diff --git a/ui/gfx/font_names_testing.h b/ui/gfx/font_names_testing.h
new file mode 100644
index 0000000000000000000000000000000000000000..e8176edeec451254cd4493ebcd4d300605a70a56
--- /dev/null
+++ b/ui/gfx/font_names_testing.h
@@ -0,0 +1,18 @@
+// Copyright (c) 2016 The Chromium Authors. All rights reserved.

[Alexei Svitkine (slow), 2016/09/02 15:19:58]

No (c) for new files.

[drott, 2016/09/02 15:35:54]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef UI_GFX_FONT_NAMES_TESTING_H_
+#define UI_GFX_FONT_NAMES_TESTING_H_
+
+namespace gfx {
+
+#if defined(OS_LINUX)
+const char* const symbol_font_name = "Opensymbol";

[Alexei Svitkine (slow), 2016/09/02 15:19:58]

Naming conventions for constants is kSymbolFontName

Also, convention for defining character constants is const char[]
kSymbolFontName.

Finally, string constants should not be defined in .h files. Instead, make a
corresponding .cc file and have the declaration in the .h but the definition in
the .cc.

[drott, 2016/09/02 15:35:54]

Okay, split into .h and .cc.

+#else
+const char* const symbol_font_name = "Symbol";
+#endif
+
+};

[Alexei Svitkine (slow), 2016/09/02 15:19:58]

No ;

Add a comment // namespace gfx

[drott, 2016/09/02 15:35:54]

Done in header and new .cc file.

+
+#endif