ui/gfx/font_names_testing.h - Issue 2302313002: Configure font font names in GFX unittests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/gfx/font_names_testing.h

Issue 2302313002: Configure font font names in GFX unittests (Closed)

Patch Set: Change to OpenSymbol and make test more robust Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
	Alexei Svitkine (slow) 2016/09/02 15:19:58 No (c) for new files. No (c) for new files. drott 2016/09/02 15:35:54 Done. Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef UI_GFX_FONT_NAMES_TESTING_H_

	6 #define UI_GFX_FONT_NAMES_TESTING_H_

	7

	8 namespace gfx {

	9

	10 #if defined(OS_LINUX)

	11 const char* const symbol_font_name = "Opensymbol";
	Alexei Svitkine (slow) 2016/09/02 15:19:58 Naming conventions for constants is kSymbolFontNam Naming conventions for constants is kSymbolFontName Also, convention for defining character constants is const char[] kSymbolFontName. Finally, string constants should not be defined in .h files. Instead, make a corresponding .cc file and have the declaration in the .h but the definition in the .cc. drott 2016/09/02 15:35:54 Okay, split into .h and .cc. Okay, split into .h and .cc.
	12 #else

	13 const char* const symbol_font_name = "Symbol";

	14 #endif

	15

	16 };
	Alexei Svitkine (slow) 2016/09/02 15:19:58 No ; Add a comment // namespace gfx No ; Add a comment // namespace gfx drott 2016/09/02 15:35:54 Done in header and new .cc file. Show quoted text On 2016/09/02 at 15:19:58, Alexei Svitkine wrote: > No ; > > Add a comment // namespace gfx Done in header and new .cc file.
	17

	18 #endif

OLD	NEW