Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Unified Diff: ui/gfx/font_names_testing.cc

Issue 2302313002: Configure font font names in GFX unittests (Closed)
Patch Set: Reintroduce height based assertions now that CJK font is used in StringSizeRespectsFontListMetrics Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gfx/font_names_testing.cc
diff --git a/ui/gfx/font_names_testing.cc b/ui/gfx/font_names_testing.cc
new file mode 100644
index 0000000000000000000000000000000000000000..b088f4a8cacbd6f18ad230f0d31523e98d96ce73
--- /dev/null
+++ b/ui/gfx/font_names_testing.cc
@@ -0,0 +1,25 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ui/gfx/font_names_testing.h"
+
+#include "build/build_config.h"
+
+namespace gfx {
+
+#if defined(OS_LINUX)
+const char kSymbolFontName[] = "DejaVu Sans";
+#else
+const char kSymbolFontName[] = "Symbol";
+#endif
+
+#if defined(OS_LINUX)
+const char kCJKFontName[] = "Kochi Mincho";
+#elif defined(OS_MACOSX)
+const char kCJKFontName[] = "PingFang SC";
+#else
+const char kCJKFontName[] = "SimSun";
+#endif
+
+} // end namespace gfx
Alexei Svitkine (slow) 2016/09/06 19:48:34 This comment should just be "// namespace". You al
msw 2016/09/06 20:06:06 Actually, shouldn't it still say gfx? Like: "} //
Alexei Svitkine (slow) 2016/09/06 21:06:31 You are correct, indeed it should be "// namespace

Powered by Google App Engine
This is Rietveld 408576698