Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Side by Side Diff: ui/gfx/font_names_testing.cc

Issue 2302313002: Configure font font names in GFX unittests (Closed)
Patch Set: Reintroduce height based assertions now that CJK font is used in StringSizeRespectsFontListMetrics Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "ui/gfx/font_names_testing.h"
6
7 #include "build/build_config.h"
8
9 namespace gfx {
10
11 #if defined(OS_LINUX)
12 const char kSymbolFontName[] = "DejaVu Sans";
13 #else
14 const char kSymbolFontName[] = "Symbol";
15 #endif
16
17 #if defined(OS_LINUX)
18 const char kCJKFontName[] = "Kochi Mincho";
19 #elif defined(OS_MACOSX)
20 const char kCJKFontName[] = "PingFang SC";
21 #else
22 const char kCJKFontName[] = "SimSun";
23 #endif
24
25 } // end namespace gfx
Alexei Svitkine (slow) 2016/09/06 19:48:34 This comment should just be "// namespace". You al
msw 2016/09/06 20:06:06 Actually, shouldn't it still say gfx? Like: "} //
Alexei Svitkine (slow) 2016/09/06 21:06:31 You are correct, indeed it should be "// namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698