Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2302263002: Update layout in WebFrameWidgetImpl::textInputInfo (Closed)

Created:
4 years, 3 months ago by Xiaocheng
Modified:
4 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews, dcheng, kinuko+watch, mlamouri+watch-blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update layout in WebFrameWidgetImpl::textInputInfo This patch is a preparation for removing the update layout call from |plainText()| (DOM tree traversal version). BUG=590369 Committed: https://crrev.com/f0de8641e7f308e8a2e486dad87469bb24e6d6ea Cr-Commit-Position: refs/heads/master@{#416230}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Xiaocheng
PTAL.
4 years, 3 months ago (2016-09-02 09:36:39 UTC) #4
tkent
lgtm
4 years, 3 months ago (2016-09-02 10:07:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2302263002/1
4 years, 3 months ago (2016-09-02 10:07:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 10:11:15 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 10:13:00 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f0de8641e7f308e8a2e486dad87469bb24e6d6ea
Cr-Commit-Position: refs/heads/master@{#416230}

Powered by Google App Engine
This is Rietveld 408576698