Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

Issue 2302263002: Update layout in WebFrameWidgetImpl::textInputInfo (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 598 matching lines...) Expand 10 before | Expand all | Expand 10 after
609 info.inputMode = inputModeOfFocusedElement(); 609 info.inputMode = inputModeOfFocusedElement();
610 610
611 info.type = textInputType(); 611 info.type = textInputType();
612 info.flags = textInputFlags(); 612 info.flags = textInputFlags();
613 if (info.type == WebTextInputTypeNone) 613 if (info.type == WebTextInputTypeNone)
614 return info; 614 return info;
615 615
616 if (!focused->editor().canEdit()) 616 if (!focused->editor().canEdit())
617 return info; 617 return info;
618 618
619 // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets needs to be audited.
620 // see http://crbug.com/590369 for more details.
621 focused->document()->updateStyleAndLayoutIgnorePendingStylesheets();
622
623 DocumentLifecycle::DisallowTransitionScope disallowTransition(focused->docum ent()->lifecycle());
624
619 // Emits an object replacement character for each replaced element so that 625 // Emits an object replacement character for each replaced element so that
620 // it is exposed to IME and thus could be deleted by IME on android. 626 // it is exposed to IME and thus could be deleted by IME on android.
621 info.value = plainText(EphemeralRange::rangeOfContents(*element), TextIterat orEmitsObjectReplacementCharacter); 627 info.value = plainText(EphemeralRange::rangeOfContents(*element), TextIterat orEmitsObjectReplacementCharacter);
622 628
623 if (info.value.isEmpty()) 629 if (info.value.isEmpty())
624 return info; 630 return info;
625 631
626 EphemeralRange firstRange = firstEphemeralRangeOf(selection.selection()); 632 EphemeralRange firstRange = firstEphemeralRangeOf(selection.selection());
627 if (firstRange.isNotNull()) { 633 if (firstRange.isNotNull()) {
628 PlainTextRange plainTextRange(PlainTextRange::create(*element, firstRang e)); 634 PlainTextRange plainTextRange(PlainTextRange::create(*element, firstRang e));
(...skipping 809 matching lines...) Expand 10 before | Expand all | Expand 10 after
1438 } 1444 }
1439 1445
1440 LocalFrame* WebFrameWidgetImpl::focusedLocalFrameAvailableForIme() const 1446 LocalFrame* WebFrameWidgetImpl::focusedLocalFrameAvailableForIme() const
1441 { 1447 {
1442 if (!m_imeAcceptEvents) 1448 if (!m_imeAcceptEvents)
1443 return nullptr; 1449 return nullptr;
1444 return focusedLocalFrameInWidget(); 1450 return focusedLocalFrameInWidget();
1445 } 1451 }
1446 1452
1447 } // namespace blink 1453 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698