Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java

Issue 2302253003: Improve error handling in JavaUrlRequest (Closed)
Patch Set: Remove errant comment change Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java
index f8cde707f1d4f84fea97766dce344fdd5c2aa030..b293107b28c92f997ba1237337a5874a9da19d93 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java
@@ -891,7 +891,7 @@ public class CronetUrlRequestTest extends CronetTestBase {
}
}
};
- callback.getExecutor().execute(startAndRead);
+ callback.getExecutor().submit(startAndRead).get();
callback.waitForNextStep();
assertEquals(callback.mResponseStep, ResponseStep.ON_RECEIVED_REDIRECT);
@@ -920,7 +920,7 @@ public class CronetUrlRequestTest extends CronetTestBase {
}
}
};
- callback.getExecutor().execute(readTwice);
+ callback.getExecutor().submit(readTwice).get();
callback.waitForNextStep();
}

Powered by Google App Engine
This is Rietveld 408576698