components/cronet/android/test/javatests/src/org/chromium/net/TestUrlRequestCallback.java - Issue 2302253003: Improve error handling in JavaUrlRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/TestUrlRequestCallback.java

Issue 2302253003: Improve error handling in JavaUrlRequest (Closed)

Patch Set: Remove errant comment change Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/api/src/org/chromium/net/JavaUrlRequest.java ('K') | « components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/javatests/src/org/chromium/net/TestUrlRequestCallback.java

diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/TestUrlRequestCallback.java b/components/cronet/android/test/javatests/src/org/chromium/net/TestUrlRequestCallback.java

index 81a04df2e5ce11080e1896c833aab322afaa3ed6..958b3ddaf6ab2f5f3ff836362d5ab8600f41f4f5 100644

--- a/components/cronet/android/test/javatests/src/org/chromium/net/TestUrlRequestCallback.java

+++ b/components/cronet/android/test/javatests/src/org/chromium/net/TestUrlRequestCallback.java

@@ -15,7 +15,6 @@ import static junit.framework.Assert.assertTrue;

import java.nio.ByteBuffer;

import java.util.ArrayList;

-import java.util.concurrent.Executor;

import java.util.concurrent.ExecutorService;

import java.util.concurrent.Executors;

import java.util.concurrent.ThreadFactory;

@@ -134,7 +133,7 @@ class TestUrlRequestCallback extends UrlRequest.Callback {

mStepBlock.close();

}

- public Executor getExecutor() {

+ public ExecutorService getExecutor() {

return mExecutorService;

}