Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 23022005: Fix Math.round/floor that had bogus Smi representation (Closed)

Created:
7 years, 4 months ago by Jakob Kummerow
Modified:
7 years, 4 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Fix Math.round/floor that had bogus Smi representation BUG=chromium:272564 R=verwaest@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16185

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -38 lines) Patch
M src/hydrogen-instructions.h View 3 chunks +1 line, -21 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-272564.js View 1 chunk +14 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
PTAL.
7 years, 4 months ago (2013-08-14 11:54:27 UTC) #1
Toon Verwaest
lgtm
7 years, 4 months ago (2013-08-14 11:55:49 UTC) #2
Jakob Kummerow
7 years, 4 months ago (2013-08-14 12:14:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16185.

Powered by Google App Engine
This is Rietveld 408576698