Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: src/hydrogen-instructions.cc

Issue 23022005: Fix Math.round/floor that had bogus Smi representation (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen-instructions.h ('k') | test/mjsunit/regress/regress-crbug-272564.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3157 matching lines...) Expand 10 before | Expand all | Expand 10 after
3168 } 3168 }
3169 3169
3170 3170
3171 Representation HUnaryMathOperation::RepresentationFromInputs() { 3171 Representation HUnaryMathOperation::RepresentationFromInputs() {
3172 Representation rep = representation(); 3172 Representation rep = representation();
3173 // If any of the actual input representation is more general than what we 3173 // If any of the actual input representation is more general than what we
3174 // have so far but not Tagged, use that representation instead. 3174 // have so far but not Tagged, use that representation instead.
3175 Representation input_rep = value()->representation(); 3175 Representation input_rep = value()->representation();
3176 if (!input_rep.IsTagged()) { 3176 if (!input_rep.IsTagged()) {
3177 rep = rep.generalize(input_rep); 3177 rep = rep.generalize(input_rep);
3178 } else if (flexible_int()) {
3179 rep = Representation::Integer32();
3180 } 3178 }
3181 return rep; 3179 return rep;
3182 } 3180 }
3183 3181
3184 3182
3185 void HAllocate::HandleSideEffectDominator(GVNFlag side_effect, 3183 void HAllocate::HandleSideEffectDominator(GVNFlag side_effect,
3186 HValue* dominator) { 3184 HValue* dominator) {
3187 ASSERT(side_effect == kChangesNewSpacePromotion); 3185 ASSERT(side_effect == kChangesNewSpacePromotion);
3188 if (!FLAG_use_allocation_folding) return; 3186 if (!FLAG_use_allocation_folding) return;
3189 3187
(...skipping 809 matching lines...) Expand 10 before | Expand all | Expand 10 after
3999 break; 3997 break;
4000 case kExternalMemory: 3998 case kExternalMemory:
4001 stream->Add("[external-memory]"); 3999 stream->Add("[external-memory]");
4002 break; 4000 break;
4003 } 4001 }
4004 4002
4005 stream->Add("@%d", offset()); 4003 stream->Add("@%d", offset());
4006 } 4004 }
4007 4005
4008 } } // namespace v8::internal 4006 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/hydrogen-instructions.h ('k') | test/mjsunit/regress/regress-crbug-272564.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698