Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2302163003: [interpreter] Clarify some names and comments. (Closed)

Created:
4 years, 3 months ago by neis
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Clarify some names and comments. Also remove an unused declaration. R=bmeurer@chromium.org BUG= Committed: https://crrev.com/19039efa2ef8f3cfb0a814d377ef4d51291c9b51 Cr-Commit-Position: refs/heads/master@{#39129}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -22 lines) Patch
M src/interpreter/bytecode-array-builder.h View 1 chunk +4 lines, -7 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/interpreter/interpreter.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
neis
4 years, 3 months ago (2016-09-02 10:59:11 UTC) #1
Benedikt Meurer
LGTM.
4 years, 3 months ago (2016-09-02 11:04:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2302163003/1
4 years, 3 months ago (2016-09-02 11:05:52 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 11:32:56 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 11:33:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19039efa2ef8f3cfb0a814d377ef4d51291c9b51
Cr-Commit-Position: refs/heads/master@{#39129}

Powered by Google App Engine
This is Rietveld 408576698