Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: src/interpreter/bytecode-generator.cc

Issue 2302163003: [interpreter] Clarify some names and comments. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/interpreter/bytecode-array-builder.cc ('k') | src/interpreter/interpreter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/bytecode-generator.cc
diff --git a/src/interpreter/bytecode-generator.cc b/src/interpreter/bytecode-generator.cc
index d5fa0d0bc0fabf1bd920e75f93acfaeaff290dc7..8bb1712e33c03ecf52cb8e54f04ad542898de740 100644
--- a/src/interpreter/bytecode-generator.cc
+++ b/src/interpreter/bytecode-generator.cc
@@ -1314,7 +1314,7 @@ void BytecodeGenerator::VisitForInStatement(ForInStatement* stmt) {
builder()->JumpIfUndefined(&subject_undefined_label);
builder()->JumpIfNull(&subject_null_label);
Register receiver = register_allocator()->NewRegister();
- builder()->CastAccumulatorToJSObject(receiver);
+ builder()->ConvertAccumulatorToObject(receiver);
register_allocator()->PrepareForConsecutiveAllocations(3);
Register cache_type = register_allocator()->NextConsecutiveRegister();
@@ -1555,7 +1555,7 @@ void BytecodeGenerator::VisitClassLiteralProperties(ClassLiteral* expr,
}
VisitForAccumulatorValue(property->key());
- builder()->CastAccumulatorToName(key);
+ builder()->ConvertAccumulatorToName(key);
// The static prototype property is read only. We handle the non computed
// property name case in the parser. Since this is the only case where we
// need to check for an own read only property we special case this so we do
@@ -1845,7 +1845,7 @@ void BytecodeGenerator::VisitObjectLiteral(ObjectLiteral* expr) {
builder()->MoveRegister(literal, literal_argument);
VisitForAccumulatorValue(property->key());
- builder()->CastAccumulatorToName(key);
+ builder()->ConvertAccumulatorToName(key);
VisitForAccumulatorValue(property->value());
builder()->StoreAccumulatorInRegister(value);
VisitSetHomeObject(value, literal, property);
@@ -2955,7 +2955,7 @@ void BytecodeGenerator::VisitCountOperation(CountOperation* expr) {
old_value = register_allocator()->outer()->NewRegister();
// Convert old value into a number before saving it.
- builder()->CastAccumulatorToNumber(old_value);
+ builder()->ConvertAccumulatorToNumber(old_value);
}
// Perform +1/-1 operation.
@@ -3204,7 +3204,7 @@ void BytecodeGenerator::VisitNewLocalWithContext() {
Register extension_object = register_allocator()->NewRegister();
- builder()->CastAccumulatorToJSObject(extension_object);
+ builder()->ConvertAccumulatorToObject(extension_object);
VisitFunctionClosureForContext();
builder()->CreateWithContext(extension_object);
execution_result()->SetResultInAccumulator();
« no previous file with comments | « src/interpreter/bytecode-array-builder.cc ('k') | src/interpreter/interpreter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698