Initial error handling code

src/core/SkImageFilter.cpp

 /*
  * Copyright 2012 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkImageFilter.h"
 
 #include "SkBitmap.h"
@@ skipping 44 matching lines @@
 SkImageFilter::SkImageFilter(SkFlattenableReadBuffer& buffer)
     : fInputCount(buffer.readInt()), fInputs(new SkImageFilter*[fInputCount]) {
     for (int i = 0; i < fInputCount; i++) {
         if (buffer.readBool()) {
             fInputs[i] = static_cast<SkImageFilter*>(buffer.readFlattenable());
         } else {
             fInputs[i] = NULL;
         }
     }
     buffer.readIRect(&fCropRect);
+
+    if ((fCropRect.fLeft > fCropRect.fRight) ||
+        (fCropRect.fTop  > fCropRect.fBottom)) {
+        buffer.setError(kInvalidArgument_SkError);

[reed1, 2013/08/21 15:49:24]

Should we "reset" ourselves since we're signaling an error?

e.g. delete all of the sub-objects in fInputs and free that array?

[sugoi1, 2013/08/21 16:52:36]

I guess it depends if we intend to put error handling code everywhere or just at
the caller site. Is the caller the one to decide how to handle errors or is each
individual object responsible for that ?

+    }
 }
 
 void SkImageFilter::flatten(SkFlattenableWriteBuffer& buffer) const {
     buffer.writeInt(fInputCount);
     for (int i = 0; i < fInputCount; i++) {
         SkImageFilter* input = getInput(i);
         buffer.writeBool(input != NULL);
         if (input != NULL) {
             buffer.writeFlattenable(input);
         }
@@ skipping 87 matching lines @@
     return true;
 }
 
 bool SkImageFilter::asNewEffect(GrEffectRef**, GrTexture*, const SkIPoint& offset) const {
     return false;
 }
 
 bool SkImageFilter::asColorFilter(SkColorFilter**) const {
     return false;
 }