Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Issue 2301943002: [turbofan] Check index type for potential element aliasing. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Check index type for potential element aliasing. When deciding whether to nuke an element entry from the state table, base the decision for the index only on the type information, and don't even try to run it through the alias analyzer. R=jarin@chromium.org Committed: https://crrev.com/699ba63cc068bf3307254e4396ebdaafef540307 Cr-Commit-Position: refs/heads/master@{#39116}

Patch Set 1 #

Patch Set 2 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/compiler/load-elimination.cc View 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (11 generated)
Benedikt Meurer
4 years, 3 months ago (2016-09-01 12:32:53 UTC) #1
Jarin
lgtm
4 years, 3 months ago (2016-09-01 12:34:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301943002/20001
4 years, 3 months ago (2016-09-02 06:39:51 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-02 07:05:49 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 07:06:35 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/699ba63cc068bf3307254e4396ebdaafef540307
Cr-Commit-Position: refs/heads/master@{#39116}

Powered by Google App Engine
This is Rietveld 408576698