Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2306443003: [turbofan] Fix typing rule for CheckBounds. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix typing rule for CheckBounds. So far we used the minimum of the length instead of the maximum to compute the output type of the CheckBounds, but at the same time we never really used the output type yet. R=jarin@chromium.org Committed: https://crrev.com/f1c891c0716cef46e9c1e42d221e560c181d038d Cr-Commit-Position: refs/heads/master@{#39114}

Patch Set 1 #

Patch Set 2 : Fix index_type check. #

Patch Set 3 : Improve lowering a bit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M src/compiler/simplified-lowering.cc View 1 2 1 chunk +6 lines, -7 lines 0 comments Download
M src/compiler/typer.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 24 (13 generated)
Benedikt Meurer
4 years, 3 months ago (2016-09-01 12:27:13 UTC) #1
Jarin
lgtm
4 years, 3 months ago (2016-09-01 12:30:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2306443003/1
4 years, 3 months ago (2016-09-01 12:31:13 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/8033) v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 3 months ago (2016-09-01 12:56:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2306443003/20001
4 years, 3 months ago (2016-09-02 05:14:35 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/builds/8047) v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED, ...
4 years, 3 months ago (2016-09-02 05:16:46 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2306443003/40001
4 years, 3 months ago (2016-09-02 05:25:05 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/builds/8050) v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
4 years, 3 months ago (2016-09-02 05:26:57 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2306443003/40001
4 years, 3 months ago (2016-09-02 05:41:56 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-02 06:04:52 UTC) #22
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 06:05:10 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f1c891c0716cef46e9c1e42d221e560c181d038d
Cr-Commit-Position: refs/heads/master@{#39114}

Powered by Google App Engine
This is Rietveld 408576698