Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1291)

Unified Diff: chrome/browser/extensions/api/autofill_private/autofill_private_apitest.cc

Issue 2301933002: Disable more AutofillPrivateApiTest tests on Windows for flakiness (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/autofill_private/autofill_private_apitest.cc
diff --git a/chrome/browser/extensions/api/autofill_private/autofill_private_apitest.cc b/chrome/browser/extensions/api/autofill_private/autofill_private_apitest.cc
index ea98788005a3e5fa56d53ad44db1536df58821a2..2b95e0ec180b75c1bfa93e51c79fd8cc1aa9cc09 100644
--- a/chrome/browser/extensions/api/autofill_private/autofill_private_apitest.cc
+++ b/chrome/browser/extensions/api/autofill_private/autofill_private_apitest.cc
@@ -44,7 +44,13 @@ class AutofillPrivateApiTest : public ExtensionApiTest {
// TODO(hcarmona): Investigate converting these tests to unittests.
-IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, SaveAddress) {
+// TODO(crbug.com/643097) Disabled for flakiness.
+#if defined(OS_WIN)
+#define MAYBE_SaveAddress DISABLED_SaveAddress
+#else
+#define MAYBE_SaveAddress SaveAddress
+#endif // defined(OS_WIN)
+IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, MAYBE_SaveAddress) {
EXPECT_TRUE(RunAutofillSubtest("saveAddress")) << message_;
}
@@ -62,7 +68,13 @@ IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, GetAddressComponents) {
EXPECT_TRUE(RunAutofillSubtest("getAddressComponents")) << message_;
}
-IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, SaveCreditCard) {
+// TODO(crbug.com/643097) Disabled for flakiness.
+#if defined(OS_WIN)
+#define MAYBE_SaveCreditCard DISABLED_SaveCreditCard
+#else
+#define MAYBE_SaveCreditCard SaveCreditCard
+#endif // defined(OS_WIN)
+IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, MAYBE_SaveCreditCard) {
EXPECT_TRUE(RunAutofillSubtest("saveCreditCard")) << message_;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698