Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Side by Side Diff: chrome/browser/extensions/api/autofill_private/autofill_private_apitest.cc

Issue 2301933002: Disable more AutofillPrivateApiTest tests on Windows for flakiness (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/macros.h" 6 #include "base/macros.h"
7 #include "base/values.h" 7 #include "base/values.h"
8 #include "chrome/browser/extensions/extension_apitest.h" 8 #include "chrome/browser/extensions/extension_apitest.h"
9 #include "chrome/common/extensions/api/autofill_private.h" 9 #include "chrome/common/extensions/api/autofill_private.h"
10 #include "components/keyed_service/core/keyed_service.h" 10 #include "components/keyed_service/core/keyed_service.h"
(...skipping 26 matching lines...) Expand all
37 } 37 }
38 38
39 private: 39 private:
40 DISALLOW_COPY_AND_ASSIGN(AutofillPrivateApiTest); 40 DISALLOW_COPY_AND_ASSIGN(AutofillPrivateApiTest);
41 }; 41 };
42 42
43 } // namespace 43 } // namespace
44 44
45 // TODO(hcarmona): Investigate converting these tests to unittests. 45 // TODO(hcarmona): Investigate converting these tests to unittests.
46 46
47 IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, SaveAddress) { 47 // TODO(crbug.com/643097) Disabled for flakiness.
48 #if defined(OS_WIN)
49 #define MAYBE_SaveAddress DISABLED_SaveAddress
50 #else
51 #define MAYBE_SaveAddress SaveAddress
52 #endif // defined(OS_WIN)
53 IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, MAYBE_SaveAddress) {
48 EXPECT_TRUE(RunAutofillSubtest("saveAddress")) << message_; 54 EXPECT_TRUE(RunAutofillSubtest("saveAddress")) << message_;
49 } 55 }
50 56
51 // TODO(crbug.com/643097) Disabled for flakiness. 57 // TODO(crbug.com/643097) Disabled for flakiness.
52 #if defined(OS_WIN) 58 #if defined(OS_WIN)
53 #define MAYBE_GetCountryList DISABLED_GetCountryList 59 #define MAYBE_GetCountryList DISABLED_GetCountryList
54 #else 60 #else
55 #define MAYBE_GetCountryList GetCountryList 61 #define MAYBE_GetCountryList GetCountryList
56 #endif // defined(OS_WIN) 62 #endif // defined(OS_WIN)
57 IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, MAYBE_GetCountryList) { 63 IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, MAYBE_GetCountryList) {
58 EXPECT_TRUE(RunAutofillSubtest("getCountryList")) << message_; 64 EXPECT_TRUE(RunAutofillSubtest("getCountryList")) << message_;
59 } 65 }
60 66
61 IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, GetAddressComponents) { 67 IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, GetAddressComponents) {
62 EXPECT_TRUE(RunAutofillSubtest("getAddressComponents")) << message_; 68 EXPECT_TRUE(RunAutofillSubtest("getAddressComponents")) << message_;
63 } 69 }
64 70
65 IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, SaveCreditCard) { 71 // TODO(crbug.com/643097) Disabled for flakiness.
72 #if defined(OS_WIN)
73 #define MAYBE_SaveCreditCard DISABLED_SaveCreditCard
74 #else
75 #define MAYBE_SaveCreditCard SaveCreditCard
76 #endif // defined(OS_WIN)
77 IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, MAYBE_SaveCreditCard) {
66 EXPECT_TRUE(RunAutofillSubtest("saveCreditCard")) << message_; 78 EXPECT_TRUE(RunAutofillSubtest("saveCreditCard")) << message_;
67 } 79 }
68 80
69 // TODO(crbug.com/643097) Disabled for flakiness. 81 // TODO(crbug.com/643097) Disabled for flakiness.
70 #if defined(OS_WIN) 82 #if defined(OS_WIN)
71 #define MAYBE_RemoveEntry DISABLED_RemoveEntry 83 #define MAYBE_RemoveEntry DISABLED_RemoveEntry
72 #else 84 #else
73 #define MAYBE_RemoveEntry RemoveEntry 85 #define MAYBE_RemoveEntry RemoveEntry
74 #endif // defined(OS_WIN) 86 #endif // defined(OS_WIN)
75 IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, MAYBE_RemoveEntry) { 87 IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, MAYBE_RemoveEntry) {
76 EXPECT_TRUE(RunAutofillSubtest("removeEntry")) << message_; 88 EXPECT_TRUE(RunAutofillSubtest("removeEntry")) << message_;
77 } 89 }
78 90
79 IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, ValidatePhoneNumbers) { 91 IN_PROC_BROWSER_TEST_F(AutofillPrivateApiTest, ValidatePhoneNumbers) {
80 EXPECT_TRUE(RunAutofillSubtest("ValidatePhoneNumbers")) << message_; 92 EXPECT_TRUE(RunAutofillSubtest("ValidatePhoneNumbers")) << message_;
81 } 93 }
82 94
83 } // namespace extensions 95 } // namespace extensions
84 96
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698