Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2301923002: ParserBase: Simplify FuncNameInferrer handling. (Closed)

Created:
4 years, 3 months ago by marja
Modified:
4 years, 3 months ago
Reviewers:
nickie
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ParserBase: Simplify FuncNameInferrer handling. BUG= Committed: https://crrev.com/a804e9b018016490df9e1848e8271f4f8dad9c45 Cr-Commit-Position: refs/heads/master@{#39130}

Patch Set 1 #

Patch Set 2 : moar #

Patch Set 3 : code review (nikolaos@) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -60 lines) Patch
M src/parsing/parser.h View 1 2 3 chunks +14 lines, -15 lines 0 comments Download
M src/parsing/parser.cc View 1 2 3 chunks +8 lines, -3 lines 0 comments Download
M src/parsing/parser-base.h View 1 2 8 chunks +9 lines, -19 lines 0 comments Download
M src/parsing/preparser.h View 1 2 1 chunk +4 lines, -23 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
marja
ptal
4 years, 3 months ago (2016-09-02 08:06:40 UTC) #6
nickie
LGTM. This practically removes the checks for fni_ == nullptr. I presume we are convinced ...
4 years, 3 months ago (2016-09-02 10:33:32 UTC) #7
marja
Done; I'm somewhat indifferent towards DCHECK_NOT_NULL because without it, we'll just crash anyway and with ...
4 years, 3 months ago (2016-09-02 11:21:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301923002/40001
4 years, 3 months ago (2016-09-02 11:21:11 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-02 11:44:52 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 11:45:36 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a804e9b018016490df9e1848e8271f4f8dad9c45
Cr-Commit-Position: refs/heads/master@{#39130}

Powered by Google App Engine
This is Rietveld 408576698