Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: src/parsing/preparser.h

Issue 2301923002: ParserBase: Simplify FuncNameInferrer handling. (Closed)
Patch Set: code review (nikolaos@) Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/parsing/parser-base.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parsing/preparser.h
diff --git a/src/parsing/preparser.h b/src/parsing/preparser.h
index a8db6fedc6515f05319e352502bdacc817c8c1b6..76868e8a5d75414db77f5e98076d9c1710e44fad 100644
--- a/src/parsing/preparser.h
+++ b/src/parsing/preparser.h
@@ -906,29 +906,10 @@ class PreParser : public ParserBase<PreParser> {
// Functions for encapsulating the differences between parsing and preparsing;
// operations interleaved with the recursive descent.
- V8_INLINE static void PushLiteralName(FuncNameInferrer* fni,
- PreParserIdentifier id) {
- // PreParser should not use FuncNameInferrer.
- UNREACHABLE();
- }
-
- V8_INLINE static void PushVariableName(FuncNameInferrer* fni,
- PreParserIdentifier id) {
- // PreParser should not use FuncNameInferrer.
- UNREACHABLE();
- }
-
- V8_INLINE void PushPropertyName(FuncNameInferrer* fni,
- PreParserExpression expression) {
- // PreParser should not use FuncNameInferrer.
- UNREACHABLE();
- }
-
- V8_INLINE static void InferFunctionName(FuncNameInferrer* fni,
- PreParserExpression expression) {
- // PreParser should not use FuncNameInferrer.
- UNREACHABLE();
- }
+ V8_INLINE static void PushLiteralName(PreParserIdentifier id) {}
+ V8_INLINE static void PushVariableName(PreParserIdentifier id) {}
+ V8_INLINE void PushPropertyName(PreParserExpression expression) {}
+ V8_INLINE static void InferFunctionName(PreParserExpression expression) {}
V8_INLINE static void CheckAssigningFunctionLiteralToProperty(
PreParserExpression left, PreParserExpression right) {}
« no previous file with comments | « src/parsing/parser-base.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698