Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2301833003: GN: Relativize occurrances of //dart (Closed)

Created:
4 years, 3 months ago by zra
Modified:
4 years, 3 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

GN: Relativize occurrances of //dart The Dart root in the Dart tree is at //, not //dart. But in the Dart tree we can refer to the root with a relative path. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/4024fe154aa437c32789b1b83ef65315d5087cf9

Patch Set 1 #

Patch Set 2 : Further cleanup. Remove unneeded rebase_path()s #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M runtime/bin/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/BUILD.gn View 1 6 chunks +8 lines, -8 lines 0 comments Download
M sdk/lib/rules.gni View 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
zra
4 years, 3 months ago (2016-09-01 17:39:50 UTC) #3
siva
lgtm
4 years, 3 months ago (2016-09-01 20:06:54 UTC) #4
zra
4 years, 3 months ago (2016-09-01 20:35:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4024fe154aa437c32789b1b83ef65315d5087cf9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698