Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: sdk/lib/rules.gni

Issue 2301833003: GN: Relativize occurrances of //dart (Closed)
Patch Set: Further cleanup. Remove unneeded rebase_path()s Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/rules.gni
diff --git a/sdk/lib/rules.gni b/sdk/lib/rules.gni
index 0aa80f87006278ef5d0e36325686390cda860cd2..27779ea97ff6fc6ec7eaec9dc720c837e462f959 100644
--- a/sdk/lib/rules.gni
+++ b/sdk/lib/rules.gni
@@ -2,6 +2,8 @@
# for details. All rights reserved. Use of this source code is governed by a
# BSD-style license that can be found in the LICENSE file.
+default_dart_root = rebase_path("../..")
+
# This build rule will copy the source for one Dart SDK library.
#
# Required arguments:
@@ -13,7 +15,7 @@
# Base path to copy sources. Default value is "$root_gen_dir/dart_sdk".
#
# dart_root
-# Path to the Dart SDK source root. Default value is "//dart".
+# Path to the Dart SDK source root. Default value is "../..".
#
# The sources will be copied into $root_gen_dir/dart_sdk/$sdk_lib_name/.
#
@@ -22,7 +24,7 @@ template("dart_sdk_lib_copy") {
if (defined(invoker.dart_root)) {
dart_root = rebase_path(invoker.dart_root)
} else {
- dart_root = rebase_path("//dart")
+ dart_root = default_dart_root
}
if (defined(invoker.destination)) {
destination = invoker.destination
« no previous file with comments | « runtime/observatory/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698