Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 2301803003: [regexp] Remove dead code (Closed)

Created:
4 years, 3 months ago by jgruber
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Remove dead code Remove dead code, and drop the legacy RegExp.prototype.exec implementation (the only differences are TO_BOOLEAN on global and sticky). BUG=v8:5339 Committed: https://crrev.com/1cb2a70cb5baa7545fdf9cc4e035a6d45cb189fd Cr-Commit-Position: refs/heads/master@{#39121}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -115 lines) Patch
M src/js/regexp.js View 4 chunks +1 line, -115 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (7 generated)
jgruber
4 years, 3 months ago (2016-09-01 11:34:30 UTC) #4
Benedikt Meurer
LGTM.
4 years, 3 months ago (2016-09-01 11:39:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301803003/1
4 years, 3 months ago (2016-09-02 08:35:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 08:37:05 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1cb2a70cb5baa7545fdf9cc4e035a6d45cb189fd Cr-Commit-Position: refs/heads/master@{#39121}
4 years, 3 months ago (2016-09-02 08:37:29 UTC) #12
jgruber
4 years, 3 months ago (2016-09-05 11:55:31 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2310903002/ by jgruber@chromium.org.

The reason for reverting is: Performance regressions: crbug.com/644087
Clusterfuzz: crbug.com/644074

We'll reland all regexp changes at once when the port is complete and at least
performance-neutral, since the partial port requires slow workarounds..

Powered by Google App Engine
This is Rietveld 408576698