Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2295273003: [regexp] Port RegExpCompile and RegExpToString (Closed)

Created:
4 years, 3 months ago by jgruber
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Port RegExpCompile and RegExpToString BUG=v8:5339 Committed: https://crrev.com/836299aa9c484eb96b6b4aa48270ab2c30b85801 Cr-Commit-Position: refs/heads/master@{#39119}

Patch Set 1 #

Patch Set 2 : Handle RegExpInitialize failures #

Patch Set 3 : Split up patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -44 lines) Patch
M src/bootstrapper.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/builtins/builtins.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins/builtins-regexp.cc View 1 2 2 chunks +67 lines, -0 lines 0 comments Download
M src/js/regexp.js View 1 2 3 chunks +0 lines, -44 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 23 (15 generated)
jgruber
4 years, 3 months ago (2016-09-01 11:30:54 UTC) #11
Benedikt Meurer
LGTM.
4 years, 3 months ago (2016-09-01 12:19:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2295273003/40001
4 years, 3 months ago (2016-09-01 12:47:18 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/builds/7831)
4 years, 3 months ago (2016-09-01 12:52:47 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2295273003/40001
4 years, 3 months ago (2016-09-02 07:44:15 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-02 08:08:40 UTC) #20
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/836299aa9c484eb96b6b4aa48270ab2c30b85801 Cr-Commit-Position: refs/heads/master@{#39119}
4 years, 3 months ago (2016-09-02 08:10:51 UTC) #22
jgruber
4 years, 3 months ago (2016-09-05 12:32:35 UTC) #23
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2311883002/ by jgruber@chromium.org.

The reason for reverting is: Performance regressions: crbug.com/644087
Clusterfuzz: crbug.com/644074

We'll reland all regexp changes at once when the port is complete and at least
performance-neutral, since the partial port requires slow workarounds..

Powered by Google App Engine
This is Rietveld 408576698