content/browser/web_contents/web_contents_impl.h - Issue 23018005: Start renderer in ContentViewCoreImpl::EvaluateJavaScript.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 23018005: Start renderer in ContentViewCoreImpl::EvaluateJavaScript. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/java/src/org/chromium/android_webview/AwContents.java ('K') | « content/browser/android/content_view_core_impl.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index 5f0766882ccc813c9447f0dd0865045b447e417c..850e0225324d2d8e82633d14bd6802fd6a1bbf4d 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -153,6 +153,13 @@ class CONTENT_EXPORT WebContentsImpl

JavaBridgeDispatcherHostManager* java_bridge_dispatcher_host_manager() const {

return java_bridge_dispatcher_host_manager_.get();

}

+ // In Android WebView, the RenderView needs created even there is no

Charlie Reis 2013/08/22 00:09:53 Wording nits in the first sentence: In Android We

+ // navigation entry, this allows Android WebViews to use

+ // javascript: URLs that load into the DOMWindow before the first page

+ // load. This is not safe to do in any context that a web page could get a

+ // reference to the DOMWindow before the first page load.

+ bool CreateRenderViewForInitialEmptyDocument();

#endif

// Expose the render manager for testing.