Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2672)

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContents.java

Issue 23018005: Start renderer in ContentViewCoreImpl::EvaluateJavaScript. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/java/src/org/chromium/android_webview/AwContents.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwContents.java b/android_webview/java/src/org/chromium/android_webview/AwContents.java
index 19eead167d57843c893c8b5be887d16d585a862c..22e88e867405c1ad2deedff4c12c05998e03c118 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwContents.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwContents.java
@@ -1367,7 +1367,8 @@ public class AwContents {
}
/**
- * @see ContentViewCore.evaluateJavaScript(String, ContentViewCOre.JavaScriptCallback)
+ * @see ContentViewCore.evaluateJavaScriptEvenIfNotYetNavigated(
+ * String, ContentViewCore.JavaScriptCallback)
*/
public void evaluateJavaScript(String script, final ValueCallback<String> callback) {
ContentViewCore.JavaScriptCallback jsCallback = null;
@@ -1380,7 +1381,7 @@ public class AwContents {
};
}
- mContentViewCore.evaluateJavaScript(script, jsCallback);
+ mContentViewCore.evaluateJavaScriptEvenIfNotYetNavigated(script, jsCallback);
joth 2013/08/22 05:44:41 Given creis's comments I don't think we want to do
michaelbai 2013/08/22 17:53:02 Done.
}
//--------------------------------------------------------------------------------------------
« no previous file with comments | « no previous file | content/browser/android/content_view_core_impl.h » ('j') | content/browser/web_contents/web_contents_impl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698