Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2301553002: Pass JavaRef to Java methods in net. (Closed)

Created:
4 years, 3 months ago by Torne
Modified:
4 years, 3 months ago
Reviewers:
asanka
CC:
android-webview-reviews_chromium.org, cbentzel+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass JavaRef to Java methods in net. Update code in net to use JavaRef when calling Java methods via JNI, instead of passing bare jobject. Various function parameter types are converted from jobject to JavaRef to enable calls to obj() higher up the call chain to be removed. BUG=506850 Committed: https://crrev.com/1cf2e5dc745a0537267a8d51f643d626e24a4d86 Cr-Commit-Position: refs/heads/master@{#415660}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -50 lines) Patch
M android_webview/native/aw_contents_client_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/android/cert_verify_result_android.h View 2 chunks +3 lines, -1 line 0 comments Download
M net/android/cert_verify_result_android.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/android/keystore.h View 5 chunks +14 lines, -9 lines 0 comments Download
M net/android/keystore.cc View 5 chunks +11 lines, -7 lines 0 comments Download
M net/android/keystore_openssl.h View 2 chunks +2 lines, -1 line 0 comments Download
M net/android/keystore_openssl.cc View 12 chunks +16 lines, -14 lines 0 comments Download
M net/android/keystore_unittest.cc View 9 chunks +10 lines, -12 lines 0 comments Download
M net/android/network_library.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/test/embedded_test_server/android/embedded_test_server_android.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/test/embedded_test_server/android/embedded_test_server_android.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Torne
This is a followup to https://codereview.chromium.org/2237943002/ which removed all the .obj() calls from places where ...
4 years, 3 months ago (2016-08-31 15:39:38 UTC) #2
asanka
lgtm
4 years, 3 months ago (2016-08-31 15:56:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301553002/1
4 years, 3 months ago (2016-08-31 15:58:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 16:50:19 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 16:52:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1cf2e5dc745a0537267a8d51f643d626e24a4d86
Cr-Commit-Position: refs/heads/master@{#415660}

Powered by Google App Engine
This is Rietveld 408576698