Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2301453002: Quic use reduced PING timeout when previous connection times out with open streams (Closed)

Created:
4 years, 3 months ago by Zhongyi Shi
Modified:
4 years, 3 months ago
Reviewers:
ianswett, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Quic use reduced PING timeout when previous connection times out with open streams the reduced ping timeout is controlled by a field trial param. BUG= Committed: https://crrev.com/dd1439f61807327301c7a0aacc3cb30802529280 Cr-Commit-Position: refs/heads/master@{#416162}

Patch Set 1 #

Total comments: 4

Patch Set 2 : address rch's comments #

Total comments: 6

Patch Set 3 : address nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -3 lines) Patch
M components/network_session_configurator/network_session_configurator.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M components/network_session_configurator/network_session_configurator_unittest.cc View 2 chunks +31 lines, -0 lines 0 comments Download
M net/http/http_network_session.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/http/http_network_session.cc View 3 chunks +4 lines, -0 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_session.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/chromium/quic_stream_factory.h View 1 2 3 chunks +8 lines, -0 lines 0 comments Download
M net/quic/chromium/quic_stream_factory.cc View 1 4 chunks +12 lines, -0 lines 0 comments Download
M net/quic/chromium/quic_stream_factory_test.cc View 1 4 chunks +114 lines, -1 line 0 comments Download
M net/quic/core/quic_connection.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M net/quic/core/quic_connection.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_stream_factory_peer.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_stream_factory_peer.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
Zhongyi Shi
4 years, 3 months ago (2016-08-31 03:28:50 UTC) #4
Ryan Hamilton
looking good. A couple of nits. https://codereview.chromium.org/2301453002/diff/1/net/quic/chromium/quic_chromium_client_session.cc File net/quic/chromium/quic_chromium_client_session.cc (right): https://codereview.chromium.org/2301453002/diff/1/net/quic/chromium/quic_chromium_client_session.cc#newcode882 net/quic/chromium/quic_chromium_client_session.cc:882: stream_factory_->set_reduced_ping_timeout(); nit: I'd ...
4 years, 3 months ago (2016-09-01 16:36:14 UTC) #7
Zhongyi Shi
Ryan: ptal, thanks! https://codereview.chromium.org/2301453002/diff/1/net/quic/chromium/quic_chromium_client_session.cc File net/quic/chromium/quic_chromium_client_session.cc (right): https://codereview.chromium.org/2301453002/diff/1/net/quic/chromium/quic_chromium_client_session.cc#newcode882 net/quic/chromium/quic_chromium_client_session.cc:882: stream_factory_->set_reduced_ping_timeout(); On 2016/09/01 16:36:14, Ryan Hamilton ...
4 years, 3 months ago (2016-09-01 18:58:30 UTC) #8
Ryan Hamilton
lgtm https://codereview.chromium.org/2301453002/diff/20001/net/quic/chromium/quic_chromium_client_session.cc File net/quic/chromium/quic_chromium_client_session.cc (right): https://codereview.chromium.org/2301453002/diff/20001/net/quic/chromium/quic_chromium_client_session.cc#newcode879 net/quic/chromium/quic_chromium_client_session.cc:879: // Notify the factory the connection times out ...
4 years, 3 months ago (2016-09-01 19:52:15 UTC) #9
ianswett
One high level question. It appears this occurs on timeouts from open streams, which seems ...
4 years, 3 months ago (2016-09-01 20:04:15 UTC) #10
Zhongyi Shi
On 2016/09/01 20:04:15, ianswett wrote: > One high level question. It appears this occurs on ...
4 years, 3 months ago (2016-09-02 00:48:05 UTC) #11
Zhongyi Shi
https://codereview.chromium.org/2301453002/diff/20001/net/http/http_network_session.cc File net/http/http_network_session.cc (right): https://codereview.chromium.org/2301453002/diff/20001/net/http/http_network_session.cc#newcode125 net/http/http_network_session.cc:125: quic_reduced_ping_timeout_seconds(kPingTimeoutSecs), On 2016/09/01 20:04:15, ianswett wrote: > nit: kDefaultPingTimeoutSecs? ...
4 years, 3 months ago (2016-09-02 00:48:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301453002/40001
4 years, 3 months ago (2016-09-02 00:48:48 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-02 02:02:43 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 02:04:24 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/dd1439f61807327301c7a0aacc3cb30802529280
Cr-Commit-Position: refs/heads/master@{#416162}

Powered by Google App Engine
This is Rietveld 408576698