Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: net/quic/chromium/quic_chromium_client_session.cc

Issue 2301453002: Quic use reduced PING timeout when previous connection times out with open streams (Closed)
Patch Set: address rch's comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/chromium/quic_chromium_client_session.h" 5 #include "net/quic/chromium/quic_chromium_client_session.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/callback_helpers.h" 9 #include "base/callback_helpers.h"
10 #include "base/location.h" 10 #include "base/location.h"
(...skipping 858 matching lines...) Expand 10 before | Expand all | Expand 10 after
869 histogram->AddCount(error, num_streams); 869 histogram->AddCount(error, num_streams);
870 } 870 }
871 UMA_HISTOGRAM_SPARSE_SLOWLY( 871 UMA_HISTOGRAM_SPARSE_SLOWLY(
872 "Net.QuicSession.ConnectionCloseErrorCodeClient", error); 872 "Net.QuicSession.ConnectionCloseErrorCodeClient", error);
873 } 873 }
874 874
875 if (error == QUIC_NETWORK_IDLE_TIMEOUT) { 875 if (error == QUIC_NETWORK_IDLE_TIMEOUT) {
876 UMA_HISTOGRAM_COUNTS( 876 UMA_HISTOGRAM_COUNTS(
877 "Net.QuicSession.ConnectionClose.NumOpenStreams.TimedOut", 877 "Net.QuicSession.ConnectionClose.NumOpenStreams.TimedOut",
878 GetNumOpenOutgoingStreams()); 878 GetNumOpenOutgoingStreams());
879 // Notify the factory the connection times out with open streams.
Ryan Hamilton 2016/09/01 19:52:15 nit: times->timed.
Zhongyi Shi 2016/09/02 00:48:21 Done.
880 if (GetNumOpenOutgoingStreams() > 0 && stream_factory_) {
881 stream_factory_->OnTimeoutWithOpenStreams();
882 }
879 if (IsCryptoHandshakeConfirmed()) { 883 if (IsCryptoHandshakeConfirmed()) {
880 if (GetNumOpenOutgoingStreams() > 0) { 884 if (GetNumOpenOutgoingStreams() > 0) {
881 disabled_reason_ = QUIC_DISABLED_TIMEOUT_WITH_OPEN_STREAMS; 885 disabled_reason_ = QUIC_DISABLED_TIMEOUT_WITH_OPEN_STREAMS;
882 UMA_HISTOGRAM_BOOLEAN( 886 UMA_HISTOGRAM_BOOLEAN(
883 "Net.QuicSession.TimedOutWithOpenStreams.HasUnackedPackets", 887 "Net.QuicSession.TimedOutWithOpenStreams.HasUnackedPackets",
884 connection()->sent_packet_manager().HasUnackedPackets()); 888 connection()->sent_packet_manager().HasUnackedPackets());
885 UMA_HISTOGRAM_COUNTS( 889 UMA_HISTOGRAM_COUNTS(
886 "Net.QuicSession.TimedOutWithOpenStreams.ConsecutiveRTOCount", 890 "Net.QuicSession.TimedOutWithOpenStreams.ConsecutiveRTOCount",
887 connection()->sent_packet_manager().GetConsecutiveRtoCount()); 891 connection()->sent_packet_manager().GetConsecutiveRtoCount());
888 UMA_HISTOGRAM_COUNTS( 892 UMA_HISTOGRAM_COUNTS(
(...skipping 334 matching lines...) Expand 10 before | Expand all | Expand 10 after
1223 } 1227 }
1224 1228
1225 void QuicChromiumClientSession::DeletePromised( 1229 void QuicChromiumClientSession::DeletePromised(
1226 QuicClientPromisedInfo* promised) { 1230 QuicClientPromisedInfo* promised) {
1227 if (IsOpenStream(promised->id())) 1231 if (IsOpenStream(promised->id()))
1228 streams_pushed_and_claimed_count_++; 1232 streams_pushed_and_claimed_count_++;
1229 QuicClientSessionBase::DeletePromised(promised); 1233 QuicClientSessionBase::DeletePromised(promised);
1230 } 1234 }
1231 1235
1232 } // namespace net 1236 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698