Move more of webcore_remaining into GN build files.

Move more of webcore_remaining into GN build files.

This makes more GN build files for various subdirectories of core and adds the
file lists from the .gypi to those files.

Since there are now so many places requring WebCOre boilerplate, this adds a
new template for defining core components that automatically does most setup.
This also cleans up the existing callers.

Committed: https://crrev.com/988d6c9ee633bd2eea254a108908abd7be7351b2
Committed: https://crrev.com/c64b405a766eeb59f0cc3d653e0240324193d025
Cr-Original-Commit-Position: refs/heads/master@{#416344}
Cr-Commit-Position: refs/heads/master@{#416475}

[brettw, 2016-09-02 18:13:08]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org

[brettw, 2016-09-02 18:13:34]

.

[brettw, 2016-09-02 18:13:34]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 18:14:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 20:20:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 20:20:28]

Dry run: This issue passed the CQ dry run.

[dglazkov, 2016-09-02 20:50:58]

dglazkov@chromium.org changed reviewers:
+ dglazkov@chromium.org

[dglazkov, 2016-09-02 20:51:00]

LGTM, this is great.

[brettw, 2016-09-02 21:21:20]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-09-02 21:21:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 21:27:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-02 21:28:50]

Description was changed from

==========
Move more of webcore_remaining into GN build files.

This makes more GN build files for various subdirectories of core and adds the
file lists from the .gypi to those files.

Since there are now so many places requring WebCOre boilerplate, this adds a
new template for defining core components that automatically does most setup.
This also cleans up the existing callers.
==========

to

==========
Move more of webcore_remaining into GN build files.

This makes more GN build files for various subdirectories of core and adds the
file lists from the .gypi to those files.

Since there are now so many places requring WebCOre boilerplate, this adds a
new template for defining core components that automatically does most setup.
This also cleans up the existing callers.

Committed: https://crrev.com/988d6c9ee633bd2eea254a108908abd7be7351b2
Cr-Commit-Position: refs/heads/master@{#416344}
==========

[commit-bot: I haz the power, 2016-09-02 21:28:51]

Patchset 2 (id:??) landed as
https://crrev.com/988d6c9ee633bd2eea254a108908abd7be7351b2
Cr-Commit-Position: refs/heads/master@{#416344}

[Nico, 2016-09-03 03:28:55]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2304353002/ by thakis@chromium.org.

The reason for reverting is: Trying to get
https://codereview.chromium.org/2308953002/ to apply.

[brettw, 2016-09-04 15:18:04]

Description was changed from

==========
Move more of webcore_remaining into GN build files.

This makes more GN build files for various subdirectories of core and adds the
file lists from the .gypi to those files.

Since there are now so many places requring WebCOre boilerplate, this adds a
new template for defining core components that automatically does most setup.
This also cleans up the existing callers.

Committed: https://crrev.com/988d6c9ee633bd2eea254a108908abd7be7351b2
Cr-Commit-Position: refs/heads/master@{#416344}
==========

to

==========
Move more of webcore_remaining into GN build files.

This makes more GN build files for various subdirectories of core and adds the
file lists from the .gypi to those files.

Since there are now so many places requring WebCOre boilerplate, this adds a
new template for defining core components that automatically does most setup.
This also cleans up the existing callers.

Committed: https://crrev.com/988d6c9ee633bd2eea254a108908abd7be7351b2
Cr-Commit-Position: refs/heads/master@{#416344}
==========

[brettw, 2016-09-04 15:18:12]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-09-04 15:18:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-04 16:45:02]

Description was changed from

==========
Move more of webcore_remaining into GN build files.

This makes more GN build files for various subdirectories of core and adds the
file lists from the .gypi to those files.

Since there are now so many places requring WebCOre boilerplate, this adds a
new template for defining core components that automatically does most setup.
This also cleans up the existing callers.

Committed: https://crrev.com/988d6c9ee633bd2eea254a108908abd7be7351b2
Cr-Commit-Position: refs/heads/master@{#416344}
==========

to

==========
Move more of webcore_remaining into GN build files.

This makes more GN build files for various subdirectories of core and adds the
file lists from the .gypi to those files.

Since there are now so many places requring WebCOre boilerplate, this adds a
new template for defining core components that automatically does most setup.
This also cleans up the existing callers.

Committed: https://crrev.com/988d6c9ee633bd2eea254a108908abd7be7351b2
Cr-Commit-Position: refs/heads/master@{#416344}
==========

[commit-bot: I haz the power, 2016-09-04 16:45:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-04 16:47:04]

Description was changed from

==========
Move more of webcore_remaining into GN build files.

This makes more GN build files for various subdirectories of core and adds the
file lists from the .gypi to those files.

Since there are now so many places requring WebCOre boilerplate, this adds a
new template for defining core components that automatically does most setup.
This also cleans up the existing callers.

Committed: https://crrev.com/988d6c9ee633bd2eea254a108908abd7be7351b2
Cr-Commit-Position: refs/heads/master@{#416344}
==========

to

==========
Move more of webcore_remaining into GN build files.

This makes more GN build files for various subdirectories of core and adds the
file lists from the .gypi to those files.

Since there are now so many places requring WebCOre boilerplate, this adds a
new template for defining core components that automatically does most setup.
This also cleans up the existing callers.

Committed: https://crrev.com/988d6c9ee633bd2eea254a108908abd7be7351b2
Committed: https://crrev.com/c64b405a766eeb59f0cc3d653e0240324193d025
Cr-Original-Commit-Position: refs/heads/master@{#416344}
Cr-Commit-Position: refs/heads/master@{#416475}
==========

[commit-bot: I haz the power, 2016-09-04 16:47:06]

Patchset 2 (id:??) landed as
https://crrev.com/c64b405a766eeb59f0cc3d653e0240324193d025
Cr-Commit-Position: refs/heads/master@{#416475}

[Dirk Pranke, 2016-09-06 00:35:04]

lgtm. I'm not wild about the "blink_core_sources" name, but I haven't thought of
anything obviously better, either.

[brettw, 2016-09-06 22:26:30]

On 2016/09/06 00:35:04, Dirk Pranke wrote:
> lgtm. I'm not wild about the "blink_core_sources" name, but I haven't thought
of
> anything obviously better, either.

Yeah, I spent a while thinking about naming. I didn't want to use "library" or
anything like that since this can be a source set and "library" implies
something else. I would have picked "core component" if "component" didn't
already have a well-defined (and opposing) meaning.