Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: third_party/WebKit/Source/core/BUILD.gn

Issue 2301383003: Move more of webcore_remaining into GN build files. (Closed)
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/animation/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/BUILD.gn
diff --git a/third_party/WebKit/Source/core/BUILD.gn b/third_party/WebKit/Source/core/BUILD.gn
index ca8fa6c778b19b1dbe754e12c0c1814756852bca..a6eb04fb2c8904e4d5385ecf74397cba653c4edb 100644
--- a/third_party/WebKit/Source/core/BUILD.gn
+++ b/third_party/WebKit/Source/core/BUILD.gn
@@ -150,13 +150,21 @@ component("core") {
]
deps = [
":remaining",
- ":rendering",
+ "//third_party/WebKit/Source/core/animation",
+ "//third_party/WebKit/Source/core/clipboard",
+ "//third_party/WebKit/Source/core/css",
"//third_party/WebKit/Source/core/dom",
+ "//third_party/WebKit/Source/core/editing",
"//third_party/WebKit/Source/core/events",
+ "//third_party/WebKit/Source/core/fetch",
+ "//third_party/WebKit/Source/core/fileapi",
+ "//third_party/WebKit/Source/core/frame",
"//third_party/WebKit/Source/core/html",
"//third_party/WebKit/Source/core/input",
+ "//third_party/WebKit/Source/core/layout",
"//third_party/WebKit/Source/core/layout/svg",
"//third_party/WebKit/Source/core/observer",
+ "//third_party/WebKit/Source/core/style:rendering",
"//third_party/WebKit/Source/core/style:svg",
"//third_party/WebKit/Source/core/svg",
]
@@ -184,7 +192,6 @@ target(core_link_large_target_type, "remaining") {
# the path starts with "rendering/" or not. We should tweak the .gypis a bit
# to separate out the rendering files.
sources = rebase_path(webcore_non_rendering_files, ".", "//")
- sources += rebase_path(webcore_rendering_files, ".", "//")
configs -= core_config_remove
configs += core_config_add + [
@@ -200,45 +207,14 @@ target(core_link_large_target_type, "remaining") {
":prerequisites",
]
- if (is_win) {
- cflags += [ "/wd4334" ]
- sources -= [ "layout/LayoutThemeFontProviderDefault.cpp" ]
- } else { # !is_win
- sources -= [
- "layout/LayoutThemeFontProviderWin.cpp",
- "layout/LayoutThemeWin.cpp",
- "layout/LayoutThemeWin.h",
- ]
- }
-
- if (!is_linux) {
- sources -= [
- "layout/LayoutThemeLinux.cpp",
- "layout/LayoutThemeLinux.h",
- ]
- }
-
- if (!is_android) {
- sources -= [
- "layout/LayoutThemeAndroid.cpp",
- "layout/LayoutThemeAndroid.h",
- ]
- }
-
if (is_mac) {
libs += [
"AppKit.framework",
"Carbon.framework",
]
- } else { # !is_mac
- sources -= [ "editing/commands/SmartReplaceCF.cpp" ]
}
}
-source_set("rendering") {
- # The files that go here are currently in "remaining".
-}
-
source_set("testing") {
configs += [
"//third_party/WebKit/Source:inside_blink",
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/animation/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698