Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(919)

Issue 2301323004: [DevTools] Enable TCP targets discovery by default (Closed)

Created:
4 years, 3 months ago by eostroukhov
Modified:
4 years, 3 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Enable TCP targets discovery by default BUG= Committed: https://crrev.com/5bbd44851c77407a6b7a70cf98e9d60920a00fb8 Cr-Commit-Position: refs/heads/master@{#416341}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/devtools/device/devtools_android_bridge_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
eostroukhov
4 years, 3 months ago (2016-09-02 19:12:43 UTC) #3
dgozman
lgtm
4 years, 3 months ago (2016-09-02 19:15:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301323004/1
4 years, 3 months ago (2016-09-02 19:22:10 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 21:09:21 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 21:11:11 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5bbd44851c77407a6b7a70cf98e9d60920a00fb8
Cr-Commit-Position: refs/heads/master@{#416341}

Powered by Google App Engine
This is Rietveld 408576698