Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1383)

Side by Side Diff: chrome/browser/devtools/device/devtools_android_bridge_browsertest.cc

Issue 2301323004: [DevTools] Enable TCP targets discovery by default (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/devtools/devtools_window.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 #include <algorithm> 4 #include <algorithm>
5 #include <array> 5 #include <array>
6 6
7 #include "base/values.h" 7 #include "base/values.h"
8 #include "chrome/browser/devtools/device/devtools_android_bridge.h" 8 #include "chrome/browser/devtools/device/devtools_android_bridge.h"
9 #include "chrome/browser/devtools/device/tcp_device_provider.h" 9 #include "chrome/browser/devtools/device/tcp_device_provider.h"
10 #include "chrome/browser/profiles/profile.h" 10 #include "chrome/browser/profiles/profile.h"
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 EXPECT_NE(nullptr, targets); 105 EXPECT_NE(nullptr, targets);
106 EXPECT_EQ(2ul, targets->GetSize()); 106 EXPECT_EQ(2ul, targets->GetSize());
107 107
108 std::set<std::string> actual; 108 std::set<std::string> actual;
109 for (size_t i = 0; i < targets->GetSize(); i++) { 109 for (size_t i = 0; i < targets->GetSize(); i++) {
110 std::string value; 110 std::string value;
111 targets->GetString(i, &value); 111 targets->GetString(i, &value);
112 actual.insert(value); 112 actual.insert(value);
113 } 113 }
114 EXPECT_STREQ("localhost:9222, localhost:9229", SetToString(actual).c_str()); 114 EXPECT_STREQ("localhost:9222, localhost:9229", SetToString(actual).c_str());
115 EXPECT_FALSE(service->GetBoolean(prefs::kDevToolsDiscoverTCPTargetsEnabled)); 115 EXPECT_TRUE(service->GetBoolean(prefs::kDevToolsDiscoverTCPTargetsEnabled));
116 } 116 }
117 117
118 IN_PROC_BROWSER_TEST_F(DevToolsAndroidBridgeTest, TCPEnableChange) { 118 IN_PROC_BROWSER_TEST_F(DevToolsAndroidBridgeTest, TCPEnableChange) {
119 Profile* profile = browser()->profile(); 119 Profile* profile = browser()->profile();
120 120
121 PrefService* service = profile->GetPrefs(); 121 PrefService* service = profile->GetPrefs();
122 service->ClearPref(prefs::kDevToolsTCPDiscoveryConfig); 122 service->ClearPref(prefs::kDevToolsTCPDiscoveryConfig);
123 service->ClearPref(prefs::kDevToolsDiscoverTCPTargetsEnabled); 123 service->ClearPref(prefs::kDevToolsDiscoverTCPTargetsEnabled);
124 124
125 DevToolsAndroidBridge* bridge = 125 DevToolsAndroidBridge* bridge =
126 DevToolsAndroidBridge::Factory::GetForProfile(profile); 126 DevToolsAndroidBridge::Factory::GetForProfile(profile);
127 127
128 scoped_refptr<TCPDeviceProvider> provider; 128 scoped_refptr<TCPDeviceProvider> provider;
129 int called = 0; 129 int called = 0;
130 bridge->set_tcp_provider_callback_for_test( 130 bridge->set_tcp_provider_callback_for_test(
131 base::Bind(assign_from_callback, &provider, &called)); 131 base::Bind(assign_from_callback, &provider, &called));
132 132
133 EXPECT_EQ(nullptr, provider); 133 EXPECT_NE(nullptr, provider);
134 134
135 service->SetBoolean(prefs::kDevToolsDiscoverTCPTargetsEnabled, true); 135 service->SetBoolean(prefs::kDevToolsDiscoverTCPTargetsEnabled, true);
136 136
137 EXPECT_NE(nullptr, provider); 137 EXPECT_NE(nullptr, provider);
138 EXPECT_STREQ("localhost:9222, localhost:9229", 138 EXPECT_STREQ("localhost:9222, localhost:9229",
139 AllTargetsString(provider).c_str()); 139 AllTargetsString(provider).c_str());
140 140
141 service->SetBoolean(prefs::kDevToolsDiscoverTCPTargetsEnabled, false); 141 service->SetBoolean(prefs::kDevToolsDiscoverTCPTargetsEnabled, false);
142 142
143 EXPECT_EQ(nullptr, provider); 143 EXPECT_EQ(nullptr, provider);
144 } 144 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/devtools/devtools_window.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698