Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 2301323002: Merge "Do not scroll by input.select()." to M54 branch (Closed)

Created:
4 years, 3 months ago by tkent
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Merge "Do not scroll by input.select()." to M54 branch This CL fixes a regression by crrev.com/414002. It accidentally changed select() behavior because focus() scrolls element's containers so that the selection is visible. Focus by select() should not scroll. BUG=642320 Review-Url: https://codereview.chromium.org/2295083002 Cr-Commit-Position: refs/heads/master@{#415619} (cherry picked from commit abecde4851098d8ffdb1f682b5f8745d73757b22) Committed: https://chromium.googlesource.com/chromium/src/+/212a7811565b74ac5df815a5cd2b849077a23be5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/forms/text/text-select-noscroll.html View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/forms/text/text-select-noscroll-expected.html View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
tkent
4 years, 3 months ago (2016-09-01 23:58:53 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
212a7811565b74ac5df815a5cd2b849077a23be5.

Powered by Google App Engine
This is Rietveld 408576698