Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2295083002: Do not scroll by input.select(). (Closed)

Created:
4 years, 3 months ago by tkent
Modified:
4 years, 3 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not scroll by input.select(). This CL fixes a regression by crrev.com/414002. It accidentally changed select() behavior because focus() scrolls element's containers so that the selection is visible. Focus by select() should not scroll. BUG=642320 Committed: https://crrev.com/abecde4851098d8ffdb1f682b5f8745d73757b22 Cr-Commit-Position: refs/heads/master@{#415619}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/forms/text/text-select-noscroll.html View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/forms/text/text-select-noscroll-expected.html View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
tkent
yosin@, would you review this please?
4 years, 3 months ago (2016-08-31 09:12:06 UTC) #4
yosin_UTC9
lgtm
4 years, 3 months ago (2016-08-31 09:19:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2295083002/1
4 years, 3 months ago (2016-08-31 12:44:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 12:48:03 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 12:49:49 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/abecde4851098d8ffdb1f682b5f8745d73757b22
Cr-Commit-Position: refs/heads/master@{#415619}

Powered by Google App Engine
This is Rietveld 408576698