Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 23011029: Do not start sampler thread when CpuProfiler is active (Closed)

Created:
7 years, 4 months ago by yurys
Modified:
7 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

Do not start sampler thread when CpuProfiler is active Now that CpuProfiler sends does sampling on the profile event processing thread there is no need to launch sampler thread. The latter is used only for --prof profiler. BUG=v8:2814 R=bmeurer@chromium.org, svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16430

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -66 lines) Patch
M src/cpu-profiler.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/cpu-profiler.cc View 1 5 chunks +4 lines, -33 lines 0 comments Download
M src/log.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/sampler.h View 1 chunk +3 lines, -4 lines 0 comments Download
M src/sampler.cc View 1 8 chunks +49 lines, -26 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
yurys
7 years, 4 months ago (2013-08-19 12:31:01 UTC) #1
yurys
ping
7 years, 4 months ago (2013-08-21 08:40:45 UTC) #2
Sven Panne
LGTM if we have test cases for this (I'm relatively sure about this for the ...
7 years, 4 months ago (2013-08-21 10:07:16 UTC) #3
yurys
On 2013/08/21 10:07:16, Sven Panne wrote: > LGTM if we have test cases for this ...
7 years, 4 months ago (2013-08-23 06:32:19 UTC) #4
Benedikt Meurer
LGTM
7 years, 3 months ago (2013-08-27 13:58:11 UTC) #5
yurys
7 years, 3 months ago (2013-08-29 14:04:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r16430 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698