Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1008)

Unified Diff: src/cpu-profiler.cc

Issue 23011029: Do not start sampler thread when CpuProfiler is active (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebase Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/cpu-profiler.h ('k') | src/log.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/cpu-profiler.cc
diff --git a/src/cpu-profiler.cc b/src/cpu-profiler.cc
index 74d1f039b6262fc080f53a356117a5583bd913d4..34bebb8eca1bfe8cd220240ff297fa972d8430f4 100644
--- a/src/cpu-profiler.cc
+++ b/src/cpu-profiler.cc
@@ -139,24 +139,9 @@ void ProfilerEventsProcessor::ProcessEventsAndDoSample() {
}
-void ProfilerEventsProcessor::ProcessEventsAndYield() {
- // Process ticks until we have any.
- if (ProcessTicks()) {
- // All ticks of the current dequeue_order are processed,
- // proceed to the next code event.
- ProcessCodeEvent();
- }
- YieldCPU();
-}
-
-
void ProfilerEventsProcessor::Run() {
while (running_) {
- if (Sampler::CanSampleOnProfilerEventsProcessorThread()) {
- ProcessEventsAndDoSample();
- } else {
- ProcessEventsAndYield();
- }
+ ProcessEventsAndDoSample();
}
// Process remaining tick events.
@@ -382,7 +367,6 @@ CpuProfiler::CpuProfiler(Isolate* isolate)
next_profile_uid_(1),
generator_(NULL),
processor_(NULL),
- need_to_stop_sampler_(false),
is_profiling_(false) {
}
@@ -396,7 +380,6 @@ CpuProfiler::CpuProfiler(Isolate* isolate,
next_profile_uid_(1),
generator_(test_generator),
processor_(test_processor),
- need_to_stop_sampler_(false),
is_profiling_(false) {
}
@@ -447,14 +430,8 @@ void CpuProfiler::StartProcessorIfNotStarted() {
logger->LogAccessorCallbacks();
LogBuiltins();
// Enable stack sampling.
- if (Sampler::CanSampleOnProfilerEventsProcessorThread()) {
- sampler->SetHasProcessingThread(true);
- }
+ sampler->SetHasProcessingThread(true);
sampler->IncreaseProfilingDepth();
- if (!sampler->IsActive()) {
- sampler->Start();
- need_to_stop_sampler_ = true;
- }
processor_->StartSynchronously();
}
}
@@ -487,20 +464,14 @@ void CpuProfiler::StopProcessorIfLastProfile(const char* title) {
void CpuProfiler::StopProcessor() {
Logger* logger = isolate_->logger();
Sampler* sampler = reinterpret_cast<Sampler*>(logger->ticker_);
- sampler->DecreaseProfilingDepth();
is_profiling_ = false;
processor_->StopSynchronously();
delete processor_;
delete generator_;
processor_ = NULL;
generator_ = NULL;
- if (Sampler::CanSampleOnProfilerEventsProcessorThread()) {
- sampler->SetHasProcessingThread(false);
- }
- if (need_to_stop_sampler_) {
- sampler->Stop();
- need_to_stop_sampler_ = false;
- }
+ sampler->SetHasProcessingThread(false);
+ sampler->DecreaseProfilingDepth();
logger->is_logging_ = saved_is_logging_;
}
« no previous file with comments | « src/cpu-profiler.h ('k') | src/log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698