media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java - Issue 2301043006: Image Capture: wire RedEyeReduction getter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java

Issue 2301043006: Image Capture: wire RedEyeReduction getter (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java ('k') | media/capture/video/android/photo_capabilities.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java

diff --git a/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java b/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java

index a1d2867fc759eb526b5db337726adbf35f02d733..f700dde2734b97d7f5a791dadae8e39ab0c3db0f 100644

--- a/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java

+++ b/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java

@@ -725,7 +725,11 @@ public class VideoCaptureCamera2 extends VideoCapture {

// CONTROL_AE_MODE overrides FLASH_MODE control unless it's in ON or OFF states.

switch (mPreviewRequest.get(CaptureRequest.CONTROL_AE_MODE)) {

case CameraMetadata.CONTROL_AE_MODE_ON_AUTO_FLASH:

+ builder.setRedEyeReduction(false);

Reilly Grant (use Gerrit) 2016/09/06 17:54:46 If the default is false (it should be since we don

mcasas 2016/09/06 18:48:53 Done. (Note that fall throughs are not allowed)

+ builder.setFillLightMode(AndroidFillLightMode.AUTO);

+ break;

case CameraMetadata.CONTROL_AE_MODE_ON_AUTO_FLASH_REDEYE:

+ builder.setRedEyeReduction(true);

builder.setFillLightMode(AndroidFillLightMode.AUTO);

break;

case CameraMetadata.CONTROL_AE_MODE_ON_ALWAYS_FLASH: