Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2301043006: Image Capture: wire RedEyeReduction getter (Closed)

Created:
4 years, 3 months ago by mcasas
Modified:
4 years, 3 months ago
CC:
Aaron Boodman, abarth-chromium, alokp+watch_chromium.org, blink-reviews, chromium-reviews, darin (slow to review), feature-media-reviews_chromium.org, haraken, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, posciak+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Image Capture: wire RedEyeReduction getter This CL lands the red-eye-reduction state getter in idl/mojom/java and updates LayoutTests accordingly. BUG=518807 Committed: https://crrev.com/b99976cc7842c8ada675256ea413977687b0cb03 Cr-Commit-Position: refs/heads/master@{#416788}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : reillyg@ comment #

Total comments: 2

Patch Set 3 : Removed superfluous builder.setRedEyeReduction(false); #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -3 lines) Patch
M media/capture/video/android/java/src/org/chromium/media/PhotoCapabilities.java View 5 chunks +16 lines, -2 lines 0 comments Download
M media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java View 1 1 chunk +4 lines, -1 line 0 comments Download
M media/capture/video/android/photo_capabilities.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/capture/video/android/photo_capabilities.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M media/capture/video/android/video_capture_device_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/capture/video/fake_video_capture_device.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/capture/video/fake_video_capture_device_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/mojo/interfaces/image_capture.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imagecapture/getphotocapabilities.html View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imagecapture/resources/mock-imagecapture.js View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.h View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.idl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
mcasas
tsepez@: image_capture.mojom (tiny change) reillyg@: PTAL
4 years, 3 months ago (2016-09-06 15:53:08 UTC) #4
Tom Sepez
mojom LGTM
4 years, 3 months ago (2016-09-06 17:53:46 UTC) #5
Reilly Grant (use Gerrit)
https://codereview.chromium.org/2301043006/diff/20001/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java File media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java (right): https://codereview.chromium.org/2301043006/diff/20001/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java#newcode728 media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java:728: builder.setRedEyeReduction(false); If the default is false (it should be ...
4 years, 3 months ago (2016-09-06 17:54:47 UTC) #6
mcasas
reillyg@ PTAL https://codereview.chromium.org/2301043006/diff/20001/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java File media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java (right): https://codereview.chromium.org/2301043006/diff/20001/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java#newcode728 media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java:728: builder.setRedEyeReduction(false); On 2016/09/06 17:54:46, Reilly Grant wrote: ...
4 years, 3 months ago (2016-09-06 18:48:53 UTC) #7
Reilly Grant (use Gerrit)
lgtm with one nit https://codereview.chromium.org/2301043006/diff/40001/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java File media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java (right): https://codereview.chromium.org/2301043006/diff/40001/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java#newcode396 media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java:396: builder.setRedEyeReduction(false); Same up here.
4 years, 3 months ago (2016-09-06 19:02:47 UTC) #8
mcasas
https://codereview.chromium.org/2301043006/diff/40001/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java File media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java (right): https://codereview.chromium.org/2301043006/diff/40001/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java#newcode396 media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java:396: builder.setRedEyeReduction(false); On 2016/09/06 19:02:46, Reilly Grant wrote: > Same ...
4 years, 3 months ago (2016-09-06 22:48:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301043006/60001
4 years, 3 months ago (2016-09-06 22:49:47 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 3 months ago (2016-09-07 00:13:25 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 00:15:58 UTC) #16
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/b99976cc7842c8ada675256ea413977687b0cb03
Cr-Commit-Position: refs/heads/master@{#416788}

Powered by Google App Engine
This is Rietveld 408576698