chrome/browser/resources/settings/internet_page/network_apnlist.html - Issue 2300783002: MD Settings: Internet: Cleanup JS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/internet_page/network_apnlist.html

Issue 2300783002: MD Settings: Internet: Cleanup JS (Closed)

Patch Set: Feedback Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/internet_page/internet_page.js ('k') | chrome/browser/resources/settings/internet_page/network_apnlist.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/internet_page/network_apnlist.html

diff --git a/chrome/browser/resources/settings/internet_page/network_apnlist.html b/chrome/browser/resources/settings/internet_page/network_apnlist.html

index d5451bde3013898114edef4be1e3dcc5d709955b..4060cafe2c66df8f50cca2bdaca52ab36557dffe 100644

--- a/chrome/browser/resources/settings/internet_page/network_apnlist.html

+++ b/chrome/browser/resources/settings/internet_page/network_apnlist.html

@@ -14,8 +14,8 @@

<paper-dropdown-menu-light vertical-align="auto" no-label-float>

<paper-listbox id="selectApn"

class="dropdown-content" on-iron-activate="onSelectApnChange_"

- selected="{{selectedApn}}" attr-for-selected="value">

- <template is="dom-repeat" items="[[apnSelectList]]">

+ selected="{{selectedApn_}}" attr-for-selected="value">

+ <template is="dom-repeat" items="[[apnSelectList_]]">

<button class="dropdown-item" role="option"

value="[[item.AccessPointName]]">

[[apnDesc_(item)]]

@@ -26,9 +26,9 @@

</div>

<div class="settings-box continuation single-column"

- hidden$="[[!isOtherSelected_(networkProperties, selectedApn)]]">

+ hidden$="[[!isOtherSelected_(selectedApn_, networkProperties)]]">

<network-property-list on-property-change="onOtherApnChange_"

- fields="[[otherApnFields_]]" property-dict="[[otherApn]]"

+ fields="[[otherApnFields_]]" property-dict="[[otherApn_]]"

edit-field-types="[[otherApnEditTypes_]]" prefix="Cellular.APN.">

</network-property-list>

<paper-button on-tap="onSaveOtherTap_">