Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Unified Diff: chrome/browser/resources/settings/internet_page/internet_page.js

Issue 2300783002: MD Settings: Internet: Cleanup JS (Closed)
Patch Set: Feedback Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/internet_page/internet_page.js
diff --git a/chrome/browser/resources/settings/internet_page/internet_page.js b/chrome/browser/resources/settings/internet_page/internet_page.js
index 8a66af47211a5630e29936f67bc5b6478856ed21..143d03579eca174fa0f4ccd5b6de781f49959558 100644
--- a/chrome/browser/resources/settings/internet_page/internet_page.js
+++ b/chrome/browser/resources/settings/internet_page/internet_page.js
@@ -11,17 +11,6 @@ Polymer({
is: 'settings-internet-page',
properties: {
- /** The network type for the known networks subpage. */
- knownNetworksType: {
- type: String,
- },
-
- /** Whether the 'Add connection' section is expanded. */
- addConnectionExpanded: {
- type: Boolean,
- value: false,
- },
-
/**
* Interface for networkingPrivate calls. May be overriden by tests.
* @type {NetworkingPrivate}
@@ -30,6 +19,21 @@ Polymer({
type: Object,
value: chrome.networkingPrivate,
},
+
+ /**
+ * The network type for the known networks subpage.
+ * @private
+ */
+ knownNetworksType_: String,
+
+ /**
+ * Whether the 'Add connection' section is expanded.
+ * @private
+ */
+ addConnectionExpanded_: {
+ type: Boolean,
+ value: false,
+ },
},
/**
@@ -47,7 +51,7 @@ Polymer({
* @private
*/
onShowKnownNetworks_: function(event) {
- this.knownNetworksType = event.detail.type;
+ this.knownNetworksType_ = event.detail.type;
settings.navigateTo(settings.Route.KNOWN_NETWORKS);
},
@@ -59,7 +63,7 @@ Polymer({
onExpandAddConnectionsTap_: function(event) {
if (event.target.id == 'expandAddConnections')
return;
- this.addConnectionExpanded = !this.addConnectionExpanded;
+ this.addConnectionExpanded_ = !this.addConnectionExpanded_;
},
/*** @private */

Powered by Google App Engine
This is Rietveld 408576698