Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2300763002: Revert of Fragment blocks with non-visible overflow as normally when printing. (Closed)

Created:
4 years, 3 months ago by paulmeyer
Modified:
4 years, 3 months ago
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, mstensho (USE GERRIT)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fragment blocks with non-visible overflow as normally when printing. (patchset #1 id:1 of https://codereview.chromium.org/2298193002/ ) Reason for revert: Suspected cause of "virtual/threaded/fast/scroll-behavior/smooth-scroll/main-thread-scrolling-reason-correctness.html" failures in webkit_tests on "WebKit Linux (dbg)" bot. example: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/9099 Original issue's description: > Fragment blocks with non-visible overflow as normally when printing. > > Splitting scrollbars into multiple fragmentainers is only problematic in > interactive media. We don't need to impose any such pagination restrictions > when printing, since printing is non-interactive, > > BUG=641983 > > Committed: https://crrev.com/53d4d7aff8e25eae2ece5bbf5a53eec940871fa8 > Cr-Commit-Position: refs/heads/master@{#415645} TBR=eae@chromium.org,mstensho@opera.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=641983 Committed: https://crrev.com/0928918d8e570a7367a571d158a34933077e7022 Cr-Commit-Position: refs/heads/master@{#415712}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -64 lines) Patch
D third_party/WebKit/LayoutTests/printing/overflow-auto.html View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/printing/overflow-auto-expected.html View 1 chunk +0 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
paulmeyer
Created Revert of Fragment blocks with non-visible overflow as normally when printing.
4 years, 3 months ago (2016-08-31 19:09:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300763002/1
4 years, 3 months ago (2016-08-31 19:10:23 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 19:11:18 UTC) #5
eae
LGTM
4 years, 3 months ago (2016-08-31 19:13:25 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0928918d8e570a7367a571d158a34933077e7022 Cr-Commit-Position: refs/heads/master@{#415712}
4 years, 3 months ago (2016-08-31 19:14:28 UTC) #8
mstensho (USE GERRIT)
I think you need to keep looking for the culprit. This one should be innocent. ...
4 years, 3 months ago (2016-08-31 19:16:36 UTC) #9
mstensho (USE GERRIT)
I'd like to reland this unless we have good reasons to believe that reverting it ...
4 years, 3 months ago (2016-09-01 18:26:29 UTC) #10
paulmeyer
On 2016/09/01 18:26:29, mstensho wrote: > I'd like to reland this unless we have good ...
4 years, 3 months ago (2016-09-01 19:49:26 UTC) #11
paulmeyer
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2294883007/ by paulmeyer@chromium.org. ...
4 years, 3 months ago (2016-09-01 19:49:55 UTC) #12
mstensho (USE GERRIT)
4 years, 3 months ago (2016-09-01 19:51:40 UTC) #13
Message was sent while issue was closed.
Thanks!

Powered by Google App Engine
This is Rietveld 408576698