Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2300703007: pdfium: Fix the pdfium builder. (Closed)

Created:
4 years, 3 months ago by jcgregorio
Modified:
4 years, 3 months ago
Reviewers:
borenet, caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M infra/bots/recipe_modules/flavor/pdfium_flavor.py View 1 1 chunk +9 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-x86_64-Release-PDFium.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
jcgregorio
4 years, 3 months ago (2016-09-02 18:39:06 UTC) #3
borenet
LGTM https://codereview.chromium.org/2300703007/diff/1/infra/bots/recipe_modules/flavor/pdfium_flavor.py File infra/bots/recipe_modules/flavor/pdfium_flavor.py (right): https://codereview.chromium.org/2300703007/diff/1/infra/bots/recipe_modules/flavor/pdfium_flavor.py#newcode35 infra/bots/recipe_modules/flavor/pdfium_flavor.py:35: Nit: 4-space indent.
4 years, 3 months ago (2016-09-02 18:45:19 UTC) #4
jcgregorio
https://codereview.chromium.org/2300703007/diff/1/infra/bots/recipe_modules/flavor/pdfium_flavor.py File infra/bots/recipe_modules/flavor/pdfium_flavor.py (right): https://codereview.chromium.org/2300703007/diff/1/infra/bots/recipe_modules/flavor/pdfium_flavor.py#newcode35 infra/bots/recipe_modules/flavor/pdfium_flavor.py:35: On 2016/09/02 at 18:45:19, borenet wrote: > Nit: 4-space ...
4 years, 3 months ago (2016-09-02 19:06:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300703007/20001
4 years, 3 months ago (2016-09-02 19:06:56 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 19:36:08 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/b55d98dda1f33179986818dc67d58c5f90508a24

Powered by Google App Engine
This is Rietveld 408576698