Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: infra/bots/recipe_modules/flavor/pdfium_flavor.py

Issue 2300703007: pdfium: Fix the pdfium builder. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: review Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-x86_64-Release-PDFium.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: infra/bots/recipe_modules/flavor/pdfium_flavor.py
diff --git a/infra/bots/recipe_modules/flavor/pdfium_flavor.py b/infra/bots/recipe_modules/flavor/pdfium_flavor.py
index 12a4f808e9370737b3c9ed1c2a427cc562c840a9..7aa21b2b02c9e0cb0e63e57f173897b911d47db3 100644
--- a/infra/bots/recipe_modules/flavor/pdfium_flavor.py
+++ b/infra/bots/recipe_modules/flavor/pdfium_flavor.py
@@ -25,8 +25,15 @@ class PDFiumFlavorUtils(default_flavor.DefaultFlavorUtils):
**kwargs)
# Setup gn args.
- gn_args = ['pdf_use_skia=true', 'pdf_is_standalone=true',
- 'clang_use_chrome_plugins=false']
+ gn_args = [
+ 'pdf_use_skia=true',
+ 'pdf_is_standalone=true',
+ 'clang_use_chrome_plugins=false',
+ 'is_component_build=false',
+ 'is_debug=false',
+ ]
+
+
env = kwargs.pop('env', {})
env['CHROMIUM_BUILDTOOLS_PATH'] = str(pdfium_dir.join('buildtools'))
self.m.run(
« no previous file with comments | « no previous file | infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-x86_64-Release-PDFium.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698