Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1795)

Unified Diff: content/renderer/render_view_impl.cc

Issue 23007021: Report Javascript Runtime Errors to the Error Console (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dc_ec_feldman
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 8c4ef11e78522307782ca8eb02dfe46d35ff8703..9029f1c2e54cc78c5b0aa62d0fa73f46f92b08d8 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -2413,12 +2413,22 @@ void RenderViewImpl::didAddMessageToConsole(
NOTREACHED();
}
+ if (shouldReportDetailedMessageForSource(source_name)) {
+ FOR_EACH_OBSERVER(
+ RenderViewObserver,
+ observers_,
+ OnDetailedConsoleMessageAdded(message.text,
+ source_name,
+ stack_trace,
+ source_line,
+ static_cast<int32>(log_severity)));
+ }
+
Send(new ViewHostMsg_AddMessageToConsole(routing_id_,
static_cast<int32>(log_severity),
message.text,
static_cast<int32>(source_line),
- source_name,
- stack_trace));
+ source_name));
}
void RenderViewImpl::printPage(WebFrame* frame) {

Powered by Google App Engine
This is Rietveld 408576698