Report Javascript Runtime Errors to the Error Console

content/public/renderer/render_view_observer.h

Index: content/public/renderer/render_view_observer.h
diff --git a/content/public/renderer/render_view_observer.h b/content/public/renderer/render_view_observer.h
index 10dad336607c8e4d37da75a257a1a93a4c3a8f63..fe0e15b5eaad521e489bb1806ee389a5c9cea1d7 100644
--- a/content/public/renderer/render_view_observer.h
+++ b/content/public/renderer/render_view_observer.h
@@ -90,6 +90,11 @@ class CONTENT_EXPORT RenderViewObserver : public IPC::Listener,
   virtual void DidHandleTouchEvent(const WebKit::WebTouchEvent& event) {}
   virtual void DidHandleGestureEvent(const WebKit::WebGestureEvent& event) {}
   virtual void DidCreatePepperPlugin(RendererPpapiHost* host) {}
+  virtual void OnDetailedConsoleMessageAdded(const base::string16& message,

[jam, 2013/08/30 16:04:39]

this doesn't match this block (i.e. it doesn't match a RenderView method)...

separate this out, add a comment, and take out the "On" prefix as by convention
that's usually for an ipc dispatcher. why do we need "detailed" as well, i.e.
isn't ConsoleMessageAdded sufficient?

[Devlin, 2013/08/30 16:33:37]

Separated, commented (with semantics for stack trace, per Joi's previous
request), s/On//.  'Detailed' was to clarify that this isn't called in all cases
when we receive a console message - only if we receive one for which we
requested extra detail (because otherwise, we take no special action).  If you
like, though, I can simplify it to ConsoleMessageAdded(). :)

+                                             const base::string16& source,
+                                             const base::string16& stack_trace,
+                                             int32 line_number,
+                                             int32 severity_level) {}
 
   // These match incoming IPCs.
   virtual void Navigate(const GURL& url) {}