Report Javascript Runtime Errors to the Error Console

content/public/renderer/render_view_observer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_RENDERER_RENDER_VIEW_OBSERVER_H_
 #define CONTENT_PUBLIC_RENDERER_RENDER_VIEW_OBSERVER_H_
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "content/common/content_export.h"
@@ skipping 72 matching lines @@
   virtual void DidRequestShowContextMenu(
       WebKit::WebFrame* frame,
       const WebKit::WebContextMenuData& data) {}
   virtual void DidCommitCompositorFrame() {}
 
   // These match the RenderView methods.
   virtual void DidHandleMouseEvent(const WebKit::WebMouseEvent& event) {}
   virtual void DidHandleTouchEvent(const WebKit::WebTouchEvent& event) {}
   virtual void DidHandleGestureEvent(const WebKit::WebGestureEvent& event) {}
   virtual void DidCreatePepperPlugin(RendererPpapiHost* host) {}
+  virtual void OnDetailedConsoleMessageAdded(const base::string16& message,

[jam, 2013/08/30 16:04:39]

this doesn't match this block (i.e. it doesn't match a RenderView method)...

separate this out, add a comment, and take out the "On" prefix as by convention
that's usually for an ipc dispatcher. why do we need "detailed" as well, i.e.
isn't ConsoleMessageAdded sufficient?

[Devlin, 2013/08/30 16:33:37]

Separated, commented (with semantics for stack trace, per Joi's previous
request), s/On//.  'Detailed' was to clarify that this isn't called in all cases
when we receive a console message - only if we receive one for which we
requested extra detail (because otherwise, we take no special action).  If you
like, though, I can simplify it to ConsoleMessageAdded(). :)

+                                             const base::string16& source,
+                                             const base::string16& stack_trace,
+                                             int32 line_number,
+                                             int32 severity_level) {}
 
   // These match incoming IPCs.
   virtual void Navigate(const GURL& url) {}
   virtual void ClosePage() {}
   virtual void OrientationChangeEvent(int orientation) {}
 
   // IPC::Listener implementation.
   virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
 
   // IPC::Sender implementation.
@@ skipping 16 matching lines @@
   RenderView* render_view_;
   // The routing ID of the associated RenderView.
   int routing_id_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderViewObserver);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_RENDERER_RENDER_VIEW_OBSERVER_H_