chrome/renderer/chrome_render_view_observer.h - Issue 23007021: Report Javascript Runtime Errors to the Error Console

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/chrome_render_view_observer.h

Issue 23007021: Report Javascript Runtime Errors to the Error Console (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dc_ec_feldman

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/chrome_content_renderer_client.cc ('k') | chrome/renderer/chrome_render_view_observer.cc » ('j') | content/public/renderer/render_view_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/chrome_render_view_observer.h

diff --git a/chrome/renderer/chrome_render_view_observer.h b/chrome/renderer/chrome_render_view_observer.h

index 67dd03e27707aea910e8e78a511ee1d512585f66..ed5039d8fd58cf9b638e3664ed930a300caf16a2 100644

--- a/chrome/renderer/chrome_render_view_observer.h

+++ b/chrome/renderer/chrome_render_view_observer.h

@@ -9,6 +9,7 @@

#include <string>

#include <vector>

+#include "base/basictypes.h"

#include "base/memory/linked_ptr.h"

#include "base/memory/scoped_ptr.h"

#include "base/timer/timer.h"

@@ -73,6 +74,11 @@ class ChromeRenderViewObserver : public content::RenderViewObserver,

virtual void DidClearWindowObject(WebKit::WebFrame* frame) OVERRIDE;

virtual void DidHandleGestureEvent(

const WebKit::WebGestureEvent& event) OVERRIDE;

+ virtual void OnDetailedConsoleMessageAdded(const base::string16& message,

+ const base::string16& source,

+ const base::string16& stack_trace,

+ int32 line_number,

+ int32 severity_level) OVERRIDE;

// WebKit::WebPermissionClient implementation.

virtual bool allowDatabase(WebKit::WebFrame* frame,